From owner-cvs-src@FreeBSD.ORG Fri Mar 31 15:14:16 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C59316A425 for ; Fri, 31 Mar 2006 15:14:16 +0000 (UTC) (envelope-from csjp@FreeBSD.org) Received: from ems01.seccuris.com (ems01.seccuris.com [204.112.0.35]) by mx1.FreeBSD.org (Postfix) with SMTP id 47F8343D5E for ; Fri, 31 Mar 2006 15:14:14 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: (qmail 6541 invoked by uid 86); 31 Mar 2006 15:22:55 -0000 Received: from unknown (HELO ?192.168.11.101?) (192.168.11.101) by ems01.seccuris.com with SMTP; 31 Mar 2006 15:22:55 -0000 Message-ID: <442D475C.2030604@FreeBSD.org> Date: Fri, 31 Mar 2006 09:14:36 -0600 From: "Christian S.J. Peron" User-Agent: Mozilla Thunderbird 1.0.7 (Macintosh/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Robert Watson References: <200603302104.k2UL4qF7086165@repoman.freebsd.org> <20060331080654.GB776@turion.vk2pj.dyndns.org> <20060331090421.I9972@fledge.watson.org> In-Reply-To: <20060331090421.I9972@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Peter Jeremy , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/usr.sbin/syslogd syslogd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2006 15:14:16 -0000 Robert Watson wrote: > > On Fri, 31 Mar 2006, Peter Jeremy wrote: > >> On Thu, 2006-Mar-30 21:04:52 +0000, Christian S.J. Peron wrote: >> >>> This change allows syslogd to ignore ENOSPC space errors, so that >>> when the >>> filesystem is cleaned up, syslogd will automatically start logging >>> again >>> without requiring the reset. This makes syslogd(8) a bit more >>> reliable. >> >> >> My sole concern with this is that this means that syslogd will keep >> trying to write to the full filesystem - and the kernel will log the >> attempts to write to a full filesystem. Whilst there's rate limiting >> in the kernel, this sort of feedback loop is undesirable. > > > What I'd like to see is an argument to syslogd to specify a maximum > full level for the target file system. Log data is valuable, but > being able to write to /var/tmp/vi.recover is also important. syslogd > -l 90% could specify that sylogd should not write log records, perhaps > other than an "out of space record" to a log file on a file system > with >=90% capacity. This prevents the kernel from spewing about > being out of space also. The accounting code does exactly this, for > identical reasons. > > Robert N M Watson > > Although I agree this is a good idea, I think it would be more appropriate to place these kinds of checks in newsyslog(8) so that other programs logging can take advantage of this. -- Christian S.J. Peron csjp@FreeBSD.ORG FreeBSD Committer FreeBSD Security Team