From owner-svn-src-head@freebsd.org Wed Jan 10 17:14:45 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E708E68CA2; Wed, 10 Jan 2018 17:14:45 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4A9437F566; Wed, 10 Jan 2018 17:14:45 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 7938AB74F; Wed, 10 Jan 2018 17:14:44 +0000 (UTC) Date: Wed, 10 Jan 2018 17:14:44 +0000 From: Alexey Dokuchaev To: Warner Losh Cc: "Rodney W. Grimes" , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh Subject: Re: svn commit: r327767 - in head/sys: conf i386/bios i386/conf i386/isa Message-ID: <20180110171444.GA85022@FreeBSD.org> References: <201801101459.w0AExJWM055025@repo.freebsd.org> <201801101631.w0AGVAEV032087@pdx.rh.CN85.dnsmgr.net> <20180110165821.GA69465@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 17:14:45 -0000 On Wed, Jan 10, 2018 at 10:01:41AM -0700, Warner Losh wrote: > On Wed, Jan 10, 2018 at 9:58 AM, Alexey Dokuchaev wrote: > > On Wed, Jan 10, 2018 at 09:48:05AM -0700, Warner Losh wrote: > > > On Wed, Jan 10, 2018 at 9:31 AM, Rodney W. Grimes wrote: > > > > > New Revision: 327767 > > > > > URL: https://svnweb.freebsd.org/changeset/base/327767 > > > > > > > > > > Log: > > > > > Retire pmtimer driver. Move time fixing into apm driver. Move > > > > > Iwasaki-san's copyright over. Remove FIXME code that couldn't > > possibly > > > > > work. Call tc_settime() with our estimate of the delta we've been > > > > > alseep (the one we print) to adjust the time. Not sure what to do > > > > > about callouts, so keep the small #ifdef in place there. > > > > > > > > > > Differential Revision: https://reviews.freebsd.org/D13823 > > > > > > > > RELNOTES: ? > > > > Reason I ask is this effects custom kernel config file(s) > > > > > > Don't know. We don't normally document every kernel config file changes > > > that's required. > > > > Well, `pmtimer' is a bit special. It is required in the kernel config in > > order to preserve time counting during suspend (not sure about amd64, but > > at least on i386, "device pmtimer" is required to be in kernel config for > > timekeeping while sleeping). > > It's only required for APM. ACPI it's a nop. > > And it didn't (until I believe that I fixed it) even adjust the time for > APM. On APM it just prints how long the sleep was. Not sure of now, but at least back in 2013 pmtimer was required on my i386 ACPI-ish laptop (it is still required now, but I just don't run -CURRENT): https://lists.freebsd.org/pipermail/svn-src-all/2013-May/069020.html ./danfe