From owner-cvs-all Mon Mar 18 18:52:19 2002 Delivered-To: cvs-all@freebsd.org Received: from espresso.q9media.com (espresso.q9media.com [216.254.138.122]) by hub.freebsd.org (Postfix) with ESMTP id 4860A37B402; Mon, 18 Mar 2002 18:52:05 -0800 (PST) Received: (from mike@localhost) by espresso.q9media.com (8.11.6/8.11.6) id g2J2kGK78387; Mon, 18 Mar 2002 21:46:16 -0500 (EST) (envelope-from mike) Date: Mon, 18 Mar 2002 21:46:16 -0500 From: Mike Barcroft To: Dag-Erling Smorgrav Cc: "J. Mallett" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/uudecode uudecode.c Message-ID: <20020318214616.K56122@espresso.q9media.com> References: <200203190205.g2J25Ru35647@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ; from des@ofug.org on Tue, Mar 19, 2002 at 03:35:48AM +0100 Organization: The FreeBSD Project Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Dag-Erling Smorgrav writes: > "J. Mallett" writes: > > Reviewed by: mike > > Approved by: mike > > You don't need both when it's the same person. Have you changed your mind since July? : Message-ID: : : "David O'Brien" writes: : > On Fri, Jul 20, 2001 at 12:05:55AM +0200, Dag-Erling Smorgrav wrote: : > > Mike Barcroft writes: : > > > Approved by: des : > > also reviewed by same. : > The assumption is if you approved something, you reviewed it. : : Not necessarily - I sometimes approve commits to code I maintain on : the basis of trust in the requesting committer's abilities. In this : particular case, however, Mike is my mentee, so I review every patch : he commits to pieces before I approve it. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message