From owner-freebsd-emulation@FreeBSD.ORG Fri Nov 20 15:36:29 2009 Return-Path: Delivered-To: freebsd-emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 69CED1065676 for ; Fri, 20 Nov 2009 15:36:29 +0000 (UTC) (envelope-from fbsd@opal.com) Received: from smtp.vzavenue.net (smtp.vzavenue.net [66.171.59.140]) by mx1.freebsd.org (Postfix) with ESMTP id 2589B8FC0A for ; Fri, 20 Nov 2009 15:36:28 +0000 (UTC) Received: from 153.78.171.66.subscriber.vzavenue.net (HELO homobox.opal.com) ([66.171.78.153]) by smtp.vzavenue.net with ESMTP; 20 Nov 2009 10:36:27 -0500 X-REPUTATION: None X-REMOTE-IP: 66.171.78.153 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAHQ+BktCq06Z/2dsb2JhbACBTtMghDwE X-IronPort-AV: i="4.44,777,1249272000"; d="scan'208"; a="211515039:sNHT19659042" Received: from opal.com (localhost [IPv6:::1]) (authenticated bits=0) by homobox.opal.com (8.14.3/8.14.3) with ESMTP id nAKFaOdV033356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 20 Nov 2009 10:36:25 -0500 (EST) (envelope-from fbsd@opal.com) Received: from shibato.opal.com ([2001:5c0:1100:f103:221:63ff:fe5a:c9a7] helo=shibato.opal.com) with IPv6:587 by opal.com; 20 Nov 2009 10:36:24 -0500 Date: Fri, 20 Nov 2009 10:36:22 -0500 From: "J.R. Oldroyd" To: Alexander Leidinger Message-ID: <20091120103622.0db845c8@shibato.opal.com> In-Reply-To: <20091120103535.815072bwgvis0io0@webmail.leidinger.net> References: <20091119153159.610debc2@shibato.opal.com> <20091120103535.815072bwgvis0io0@webmail.leidinger.net> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.16.6; amd64-portbld-freebsd7.2) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: freebsd-emulation@freebsd.org Subject: Re: Emulation of Linux V4L ioctls X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Nov 2009 15:36:29 -0000 On Fri, 20 Nov 2009 10:35:35 +0100, Alexander Leidinger wrote: > > Some things I noticed and worry about: > - videodev.h does not have a license, did you generate it > yourself or did you take it from somewhere? > - Does it needs to be named videodev.h, or can it also be > linux_videodev.h? > (if we may want to install this header at some point in time, > it should have a name compatible with linux, else we should > maybe add a linux_ prefix for consistence and for making it > very obvious what we are talking about) > - Why are you using __s32 and so on instead of the normal > fixed size int types? We also have lint for "linux int" > and so on in other files. This header is the same as the one used on Linux. In fact, I took this file from our pwcbsd driver, but it can also be found by googling for videodev.h which reveals it is /usr/include/linux/videodev.h on Linux 2.6 systems. I think it really wants to be installed in /usr/include/linux here too, since it is also useful for user apps that need these structures and definitions. But I am not sure what our policy would be for creating a /usr/include/linux dir for it. If you prefer to keep it in this dir, yes it could be renamed to linux_videodev.h. There is indeed no license in this file. The use of __s32 etc is because I used this file unchanged. > - On which architecture has this been tested? > - Will it run in linux32 emulation on amd64? Yes. I did this work on an amd64, in fact. > - Are those structures known in userland (and as such need to > have a specific size)? If yes, do they have different sizes > in linux depending if the kernel is a 64bit kernel (amd64) > or 32bit kernel (x86)? They are used in userland. Given the header's use of __s32 etc, it looks to me like the structures have the same size on both x86 and amd64. > - Has this been run through a "make universe"? > I built by compiling in sys/amd64/compile/XXX. -jr