From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Oct 28 06:00:32 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 129F916A4DA for ; Tue, 28 Oct 2003 06:00:32 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id EDB5A43FEA for ; Tue, 28 Oct 2003 06:00:27 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h9SE0RFY080875 for ; Tue, 28 Oct 2003 06:00:27 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h9SE0R0b080874; Tue, 28 Oct 2003 06:00:27 -0800 (PST) (envelope-from gnats) Resent-Date: Tue, 28 Oct 2003 06:00:27 -0800 (PST) Resent-Message-Id: <200310281400.h9SE0R0b080874@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Luigi Rizzo Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 552E416A4CF; Tue, 28 Oct 2003 05:50:16 -0800 (PST) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id D3EF743FE5; Tue, 28 Oct 2003 05:50:11 -0800 (PST) (envelope-from rizzo@xorpc.icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.9p1/8.12.3) with ESMTP id h9SDoBsd023582; Tue, 28 Oct 2003 05:50:11 -0800 (PST) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.9p1/8.12.3/Submit) id h9SDoArY023581; Tue, 28 Oct 2003 05:50:11 -0800 (PST) (envelope-from rizzo) Message-Id: <200310281350.h9SDoArY023581@xorpc.icir.org> Date: Tue, 28 Oct 2003 05:50:11 -0800 (PST) From: Luigi Rizzo To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: dinoex@FreeBSD.org Subject: ports/58630: silently drop messages in noattach (change request) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Luigi Rizzo List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2003 14:00:32 -0000 >Number: 58630 >Category: ports >Synopsis: silently drop messages in noattach (change request) >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Tue Oct 28 06:00:27 PST 2003 >Closed-Date: >Last-Modified: >Originator: Luigi Rizzo >Release: FreeBSD 4.8-RELEASE i386 >Organization: Dip.Ing.Informazione - univ.pisa >Environment: System: FreeBSD xorpc.icir.org 4.8-RELEASE FreeBSD 4.8-RELEASE #0: Mon Apr 7 20:59:56 PDT 2003 root@xorpc.icir.org:/usr/src/sys/compile/ICIR-4.8-USB i386 >Description: noattach will send a REJECT for messages it does not want to deal with. But the vast majority of these virus-generated messages contain a fake sender address, so the reject will cause an additional bounced email, or even worse a backfire towards the unlucky owner of the fake address. I have been in both categories with the recent Sobig.F virus, receiving between 60 and 80000 (yes no typo, eighty thousand) messages per day, and it is no fun. I believe it is a lot safer to silently drop unwanted messages rather than bouncing them. The attached patch does it. >How-To-Repeat: >Fix: --- noattach.c.orig Thu Aug 21 13:52:48 2003 +++ noattach.c Tue Oct 28 13:37:49 2003 @@ -651,7 +651,11 @@ safe_free(lines[i]); safe_free(lines); (void)mlfi_cleanup(ctx, true); +#if 0 return SMFIS_REJECT; +#else + return SMFIS_DISCARD; +#endif } else if (cl_err == -1) { /* can't accept this message right now */ >Release-Note: >Audit-Trail: >Unformatted: