From owner-freebsd-current@FreeBSD.ORG Fri May 4 21:19:32 2007 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id E2B4716A407 for ; Fri, 4 May 2007 21:19:32 +0000 (UTC) (envelope-from eric@anholt.net) Received: from vonnegut.anholt.net (69-30-77-85.dq1sn.easystreet.com [69.30.77.85]) by mx1.freebsd.org (Postfix) with ESMTP id 8876013C44C for ; Fri, 4 May 2007 21:19:32 +0000 (UTC) (envelope-from eric@anholt.net) Received: from vonnegut.anholt.net (localhost [127.0.0.1]) by vonnegut.anholt.net (8.13.8/8.13.8) with ESMTP id l44LFlrn054368; Fri, 4 May 2007 14:16:10 -0700 (PDT) (envelope-from eric@anholt.net) Received: (from anholt@localhost) by vonnegut.anholt.net (8.13.8/8.13.8/Submit) id l44LEWLi054364; Fri, 4 May 2007 14:14:32 -0700 (PDT) (envelope-from eric@anholt.net) X-Authentication-Warning: vonnegut.anholt.net: anholt set sender to eric@anholt.net using -f From: Eric Anholt To: Nate Lawson In-Reply-To: <463B93CD.3000302@root.org> References: <463B93CD.3000302@root.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-ZpowOhnBEoX+lwULSm5Y" Date: Fri, 04 May 2007 14:13:20 -0700 Message-Id: <1178313200.54075.3.camel@vonnegut> Mime-Version: 1.0 X-Mailer: Evolution 2.10.0 FreeBSD GNOME Team Port X-Mailman-Approved-At: Fri, 04 May 2007 22:22:40 +0000 Cc: current Subject: Re: agp_i810 not built on amd64? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2007 21:19:33 -0000 --=-ZpowOhnBEoX+lwULSm5Y Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri, 2007-05-04 at 13:13 -0700, Nate Lawson wrote: > I have a desktop with i945GMS builtin video. It appears agp_i810.c is > not built on amd64, hence no support for agp. This is on 6.x. >=20 > none0@pci0:2:0: class=3D0x030000 card=3D0x31031565 chip=3D0x27728086 rev= =3D0x02 > hdr=3D0x00 > vendor =3D 'Intel Corporation' > device =3D 'Integrated Graphics Controller' > class =3D display > subclass =3D VGA >=20 > sys/conf/files.i386:pci/agp_i810.c optional agp >=20 > $ ls /sys/amd64/compile/SMP/*agp* > /sys/amd64/compile/SMP/agp.o /sys/amd64/compile/SMP/agp_if.h > /sys/amd64/compile/SMP/agp_amd64.o /sys/amd64/compile/SMP/agp_if.o > /sys/amd64/compile/SMP/agp_if.c /sys/amd64/compile/SMP/agp_intel.= o >=20 > Is there any reason not to use i810 on amd64? A quick glance through > doesn't show it doing anything 32-bit specific. On -current, it appears > to be enabled for amd64. It appears this MFC never happened: >=20 > revision 1.93 > date: 2006/09/05 16:55:12; author: anholt; state: Exp; lines: +1 -0 > Include agp_i810.c in amd64 AGP builds to get support for the Intel 915 > Express chipsets. Nope, there's no good reason for the MFC to have not happened. We've only got one amd64 issue that I know of, but it's actually not unique to amd64. We're not allocating our pages to back aperture allocations to meet the requirements of the page tables, so for example on i915-class hardware with 4GB of ram, you'll get pages sometimes that are above the 4GB range, and we'll just drop the top bit of the address when filling in the page table, resulting in pain. We need a way for AGP drivers to communicate their requirements for AGP memory to the core, likely through busdma tags. In the current agp_i810.c patch I've been working on, I at least panic when we get out-of-range pages, instead of scribbling on random memory. --=20 Eric Anholt anholt@FreeBSD.org eric@anholt.net eric.anholt@intel.com --=-ZpowOhnBEoX+lwULSm5Y Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBGO6HtHUdvYGzw6vcRAra2AJ41OayWagf51cWIhisHM+FLAT92vQCghy61 BMOEU+rq7UCbh1+GQ9EPiSM= =+hW0 -----END PGP SIGNATURE----- --=-ZpowOhnBEoX+lwULSm5Y--