From owner-svn-src-all@FreeBSD.ORG Mon Sep 3 19:29:12 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C8C71065679; Mon, 3 Sep 2012 19:29:12 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 8BF298FC0A; Mon, 3 Sep 2012 19:29:11 +0000 (UTC) Received: by obbun3 with SMTP id un3so12668317obb.13 for ; Mon, 03 Sep 2012 12:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=956sGL9ZIOcIg6tFq3dmfkuXsoqQcDZVGplha3fgWbA=; b=P1NKQqUzQfPILegqY0bHxb5jwccPxS+TdrwL10qDepVLMlj/uYQk7WUMso2cPnWbOz sU9n1B0rFfSTrVjVeyalKYi3fW6HC6P9Mz+4M63G5qoZm/A0SEI4qi46xDx6DU4gkd+d pxNG0N40MpXCv8Tnuq3SMrSfZiwckZERNdcjziwAtyUNYhuyAX+SDqgctEY+PQiHfpO9 XIVnNOkP/AJPV3cAUPuebL9B/0eJYFvulPjjYi2snj/052RJQfIVPN/YhzUvdq/yRmGj /fRDSXgOmdmeatQXy41OH8wPYemgDXGst9Z71EruiSyW6wIms1eMaRl5ZtkaszncMf6u aeZQ== MIME-Version: 1.0 Received: by 10.60.29.164 with SMTP id l4mr15056278oeh.4.1346700545172; Mon, 03 Sep 2012 12:29:05 -0700 (PDT) Received: by 10.76.142.201 with HTTP; Mon, 3 Sep 2012 12:29:05 -0700 (PDT) In-Reply-To: <20120903122352.951b4253.ray@freebsd.org> References: <201209030852.q838q6lC053405@svn.freebsd.org> <20120903122352.951b4253.ray@freebsd.org> Date: Mon, 3 Sep 2012 12:29:05 -0700 Message-ID: From: Garrett Cooper To: Aleksandr Rybalko Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240067 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Sep 2012 19:29:12 -0000 On Mon, Sep 3, 2012 at 2:23 AM, Aleksandr Rybalko wrote: > On Mon, 3 Sep 2012 02:05:15 -0700 > Garrett Cooper wrote: > >>> On Sep 3, 2012, at 1:52 AM, Aleksandr Rybalko wrote: >>> >>> > Author: ray >>> > Date: Mon Sep 3 08:52:05 2012 >>> > New Revision: 240067 >>> > URL: http://svn.freebsd.org/changeset/base/240067 >>> > >>> > Log: >>> > Add kern.hintmode sysctl variable to show current state of hints: >>> > 0 - loader hints in environment only; >>> > 1 - static hints only >>> > 2 - fallback mode (Dynamic KENV with fallback to kernel >>> > environment) Add kern.hintmode write handler, accept only value 2. >>> > That will switch static KENV to dynamic. So it will be possible to >>> > change device hints. >>> >>> ... >>> >>> > + /* Migrate from static to dynamic hints */ >>> > + switch (hintmode) { >>> > + case 0: >>> > + if (dynamic_kenv) >>> > + /* Already here */ >>> > + hintmode = value; /* XXX: Need we switch >>> > or not ? */ >>> > + return (0); >>> >>> ^^^^ typo (missing braces)? ^^^^ > > Ohhh, yeah, testing now. > Thank you! > >>> >>> Also, don't you need extra glue for jails? > > Why, jails uses separate hints/kenv? I was wondering whether or not the tunables could be changed from the jail, thus allowing someone to affect the host system or if this memory space was effectively CoWed in some way, shape or form. Thanks! -Garrett