From owner-svn-src-projects@FreeBSD.ORG Wed Sep 15 16:42:57 2010 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5C8151065679; Wed, 15 Sep 2010 16:42:57 +0000 (UTC) (envelope-from attilio@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 4DF788FC15; Wed, 15 Sep 2010 16:42:57 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o8FGgvtR043177; Wed, 15 Sep 2010 16:42:57 GMT (envelope-from attilio@svn.freebsd.org) Received: (from attilio@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o8FGgvO5043175; Wed, 15 Sep 2010 16:42:57 GMT (envelope-from attilio@svn.freebsd.org) Message-Id: <201009151642.o8FGgvO5043175@svn.freebsd.org> From: Attilio Rao Date: Wed, 15 Sep 2010 16:42:57 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r212675 - projects/sv/sys/net X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2010 16:42:57 -0000 Author: attilio Date: Wed Sep 15 16:42:57 2010 New Revision: 212675 URL: http://svn.freebsd.org/changeset/base/212675 Log: Add a comment explaining why they need to stay out of DEVICE_POLLING. Modified: projects/sv/sys/net/if_var.h Modified: projects/sv/sys/net/if_var.h ============================================================================== --- projects/sv/sys/net/if_var.h Wed Sep 15 16:40:17 2010 (r212674) +++ projects/sv/sys/net/if_var.h Wed Sep 15 16:42:57 2010 (r212675) @@ -891,6 +891,11 @@ void if_deregister_com_alloc(u_char type #define IF_LLADDR(ifp) \ LLADDR((struct sockaddr_dl *)((ifp)->if_addr->ifa_addr)) +/* + * Keep enum poll_cmd and poll_handler_t specification unconditional from + * DEVICE_POLLING because other modules may be needing them as well + * (where the most notable one is netdump). + */ enum poll_cmd { POLL_ONLY, POLL_AND_CHECK_STATUS }; typedef int poll_handler_t(struct ifnet *ifp, enum poll_cmd cmd, int count);