Date: Mon, 18 Oct 2004 23:00:00 +0200 From: "Simon L. Nielsen" <simon@FreeBSD.org> To: =?iso-8859-1?Q?S=F8ren?= Schmidt <sos@DeepCore.dk> Cc: freebsd-current@freebsd.org Subject: Re: No booting - ata1-slave: FAILURE Message-ID: <20041018210000.GA753@zaphod.nitro.dk> In-Reply-To: <4172A2D0.2060202@DeepCore.dk> References: <4171AA66.2050005@gmx.de> <4172A2D0.2060202@DeepCore.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
--PNTmBPCT7hxwcZjr
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2004.10.17 18:50:24 +0200, S=F8ren Schmidt wrote:
> Jochen Gensch wrote:
> >Hi,
> >
> >I just cvsup'd RELENG_5 and the system is not booting any more with the=
=20
> >new kernel. It hangs at the ata identifying with the message:
> >
> >ata1-slave: FAILURE - ATAPI_IDENTIFY timed out
> >
> >I am using the GENERIC kernel, the only additional thing in there is=20
> >atapicam. Maybe I just cvsup'd at a bad time :-) ?
>=20
> Maybe not, could you please try the attached patch and let me know if=20
> that helps or not ?
I'm not sure if I dare to tell you... :-) but my Thinkpad R40 also
hangs now with RELENG_5 from today. It's OK with 5.3-BETA7 from Oct
10.
The patch below did not fix it. I haven't tried backstepping ata(4)
yet, but I will do that shortly.
> Index: ata-all.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/ncvs/src/sys/dev/ata/ata-all.c,v
> retrieving revision 1.222.2.4
> diff -u -r1.222.2.4 ata-all.c
> --- ata-all.c 16 Oct 2004 08:43:06 -0000 1.222.2.4
> +++ ata-all.c 17 Oct 2004 16:38:21 -0000
> @@ -306,6 +306,12 @@
> }
> }
> =20
> + ch->flags &=3D ~ATA_IMMEDIATE_MODE;
> + mtx_lock(&ch->state_mtx);
> + ch->state =3D ATA_IDLE;
> + mtx_unlock(&ch->state_mtx);
> + ch->locking(ch, ATA_LF_UNLOCK);
> +
> /* attach new devices */
> if ((newdev =3D ~devices & ch->devices)) {
> if ((newdev & (ATA_ATA_MASTER | ATA_ATAPI_MASTER)) &&
> @@ -323,12 +329,6 @@
> if (bootverbose)
> ata_printf(ch, -1, "device config done ..\n");
> =20
> - ch->flags &=3D ~ATA_IMMEDIATE_MODE;
> - mtx_lock(&ch->state_mtx);
> - ch->state =3D ATA_IDLE;
> - mtx_unlock(&ch->state_mtx);
> - ch->locking(ch, ATA_LF_UNLOCK);
> -
> ata_start(ch);
> return 0;
> }
--=20
Simon L. Nielsen
FreeBSD Documentation Team
--PNTmBPCT7hxwcZjr
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQFBdC7Ph9pcDSc1mlERArJxAKDKfy0CSGtNHjxbhPEQhac77KX/NACgkrwr
UyQ9AYF7ciDvdi3nwL7yhd8=
=StG5
-----END PGP SIGNATURE-----
--PNTmBPCT7hxwcZjr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041018210000.GA753>