From owner-svn-src-user@FreeBSD.ORG Mon Oct 11 20:23:00 2010 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1029A106566B for ; Mon, 11 Oct 2010 20:23:00 +0000 (UTC) (envelope-from weongyo.jeong@gmail.com) Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id A66868FC08 for ; Mon, 11 Oct 2010 20:22:59 +0000 (UTC) Received: by vws1 with SMTP id 1so1543355vws.13 for ; Mon, 11 Oct 2010 13:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:organization:x-operation-sytem; bh=AyZ94hk+m1hd6qV/yTQsGrYYQ24q4tSqFdxKOxbEaaE=; b=Yymp5EgshY81ttST+ATyOYhCnBvQ5o4CkF0XG9+h0TAwRfD1yKJq7PelajFgckW9R6 zOQSg+eVXCIQgINJ0eTnuq6w97vJ+Gax6f2bH70L6zLoCiQEmjY4NAAigwjcmZQe+DuS WH4SIpfUKTu9bOJHQZgl1yrL33iB9hPmlHONU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:mail-followup-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent:organization:x-operation-sytem; b=Tp30Xg+TlxsnBedhT+hphedUeUs2lYMhi8zyQaJGt4Va3OhbWQRNqjQABLU/tKv01C P9khtVErQJo7on1fV8zT5gPwjlv1UZCGX7gSx0A6xC97cTP/XE2B1hN0AyFA4YqlSEAJ ar485rdW+lhoZ1vIS9s+w4F+ZHGG7Z2+2gxIo= Received: by 10.220.99.141 with SMTP id u13mr1334985vcn.69.1286828118439; Mon, 11 Oct 2010 13:15:18 -0700 (PDT) Received: from weongyo ([174.35.1.224]) by mx.google.com with ESMTPS id e31sm4194571vbe.9.2010.10.11.13.15.16 (version=SSLv3 cipher=RC4-MD5); Mon, 11 Oct 2010 13:15:17 -0700 (PDT) Received: by weongyo (sSMTP sendmail emulation); Mon, 11 Oct 2010 13:15:22 -0700 From: Weongyo Jeong Date: Mon, 11 Oct 2010 13:15:22 -0700 To: Julian Elischer Message-ID: <20101011201522.GB38869@weongyo> Mail-Followup-To: Julian Elischer , Hans Petter Selasky , "src-committers@freebsd.org" , "svn-src-user@freebsd.org" References: <201010080152.o981q1gJ074407@svn.freebsd.org> <201010111739.25082.hselasky@c2i.net> <4CB33B04.8070609@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4CB33B04.8070609@freebsd.org> User-Agent: Mutt/1.4.2.3i Organization: CDNetworks. X-Operation-Sytem: FreeBSD Cc: "src-committers@freebsd.org" , "svn-src-user@freebsd.org" , Hans Petter Selasky Subject: Re: svn commit: r213540 - user/weongyo/usb/sys/dev/usb/net X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Weongyo Jeong List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Oct 2010 20:23:00 -0000 On Mon, Oct 11, 2010 at 09:27:48AM -0700, Julian Elischer wrote: > On 10/11/10 8:39 AM, Hans Petter Selasky wrote: > >On Friday 08 October 2010 03:52:01 Weongyo Jeong wrote: > >>Author: weongyo > >>Date: Fri Oct 8 01:52:01 2010 > >>New Revision: 213540 > >>URL: http://svn.freebsd.org/changeset/base/213540 > >> > >>Log: > >> o fixes a regression that setting the promiscuous mode should be > >> happened at the taskqueue. It's to avoid a `sleepable after > >> non-sleepable' because ioctl handler could be called with holding bpf > >> mtx which is a default mutex. > >> o defines SLEEPOUT_DRAIN_TASK helper. > >> > [...] > > >These taskqueues belong in the network stack and not the USB drivers! And > >please understand that you cannot use taskqueues for these commands, > >because > >the events can be executed out of order!!! > > sounds like we should add an option to taskqueues to fix this then. > I'd rather fix the standard facility than make a new one. I agree with you that if it really requires the extension for USB it'd be better to fix the taskqueue than reimplementing almost same thing (usb_process.[ch]). regards, Weongyo Jeong