Date: Tue, 21 Apr 2015 00:25:29 +0300 From: Sergey Kandaurov <pluknet@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: arch@freebsd.org, amd64@freebsd.org Subject: Re: Move x86 idle code to the x86/ common place. Message-ID: <CAE-mSO%2BgEFFRio4P3157NcSoNOpf9JifH98WqKgi9TmBu6hgvw@mail.gmail.com> In-Reply-To: <20150420162149.GE2390@kib.kiev.ua> References: <20150420162149.GE2390@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 April 2015 at 19:21, Konstantin Belousov <kostikbel@gmail.com> wrote:
[..]
> +struct {
> + void *id_fn;
> + char *id_name;
> +} idle_tbl[] = {
> + { cpu_idle_spin, "spin" },
> + { cpu_idle_mwait, "mwait" },
> + { cpu_idle_hlt, "hlt" },
> +#if !defined(__i386__) || !defined(PC98)
> + { cpu_idle_acpi, "acpi" },
> +#endif
> + { NULL, NULL }
> +};
> +
I believe this conditional could be left unchanged as #ifndef PC98
(also in several other places), given that pc98 may not be present
other than under i386. Otherwise, looks good.
--
wbr,
pluknet
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAE-mSO%2BgEFFRio4P3157NcSoNOpf9JifH98WqKgi9TmBu6hgvw>