From owner-freebsd-commit Mon May 15 06:31:36 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA00765 for commit-outgoing; Mon, 15 May 1995 06:31:36 -0700 Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id GAA00750 for cvs-usrbin-outgoing; Mon, 15 May 1995 06:31:34 -0700 Received: from sequent.kiae.su (sequent.kiae.su [144.206.136.6]) by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id GAA00735 ; Mon, 15 May 1995 06:31:11 -0700 Received: by sequent.kiae.su id AA15465 (5.65.kiae-2 ); Mon, 15 May 1995 17:26:16 +0400 Received: by sequent.KIAE.su (UUMAIL/2.0); Mon, 15 May 95 17:26:15 +0400 Received: (from ache@localhost) by astral.msk.su (8.6.8/8.6.6) id RAA00664; Mon, 15 May 1995 17:23:50 +0400 To: "Rodney W. Grimes" , Kai Vorma Cc: CVS-commiters@freefall.cdrom.com, cvs-usrbin@freefall.cdrom.com, nate@trout.sri.MT.net References: <199505150731.AAA05385@gndrsh.aac.dev.com> In-Reply-To: <199505150731.AAA05385@gndrsh.aac.dev.com>; from "Rodney W. Grimes" at Mon, 15 May 1995 00:31:18 -0700 (PDT) Message-Id: Organization: Olahm Ha-Yetzirah Date: Mon, 15 May 1995 17:23:50 +0400 (MSD) X-Mailer: Mail/@ [v2.35 FreeBSD] From: "Andrey A. Chernov, Black Mage" X-Class: Fast Subject: Re: cvs commit: src/usr.bin/rpcgen rpc_parse.c Lines: 51 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Length: 1992 Sender: commit-owner@FreeBSD.org Precedence: bulk In message <199505150731.AAA05385@gndrsh.aac.dev.com> Rodney W. Grimes writes: >> >> >> >> On Sun, 14 May 1995, Nate Williams wrote: >> >> > Andrey A. Chernov writes: >> > > ache 95/05/14 17:03:33 >> > > >> > > Modified: usr.bin/rpcgen rpc_parse.c >> > > Log: >> > > End of listcan be not marked, fix it >> > > Submitted by: Kai Vorma >> > >> > I looked at this fix, and I'm not sure that the proposed 'fix' was >> > necessary. Did you look at the fix at determine if it was indeed needed? >> >> Without this fix the last plist->next link is uninitialized. rpcgen >> still works, because the way BSD malloc works (it cannot reuse freed >> memory so it asks more from the system and that memory is zeroed -> >> next-link happens to be NULL). >> >> I have replaced the system malloc with a better one and rpcgen >> dumps core without this patch. >Then this is not a critical bug fix, becuase as ship freebsd does not >have the bug! It have, but this bag is masked with other things (side effect of malloc). You follow bad way Rod: I remember in some days we have two bugs: one in syscons and one in termcap which masked each other and complex variant do right things, according to your way we don't need to fix them. >Are you *absolutely* sure your change has no side effects that would >cause something else to break? If so I can live with this change, >if not, I am probably going to step a cvs admin -o maj.min on rpc_parse.c >and obsolete this last change until after the release is done. Rod, did you even saw whole code? I think that any one year C programmer can easily understand what happens there with and without this patch. -- Andrey A. Chernov : And I rest so composedly, /Now, in my bed, ache@astral.msk.su : That any beholder /Might fancy me dead - FidoNet: 2:5020/230.3 : Might start at beholding me, /Thinking me dead. RELCOM Team,FreeBSD Team : E.A.Poe From "For Annie" 1849