From owner-cvs-ports@FreeBSD.ORG  Sun Nov 28 15:12:52 2010
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 33DA8106567A; Sun, 28 Nov 2010 15:12:52 +0000 (UTC)
Date: Sun, 28 Nov 2010 15:12:52 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: "Philip M. Gollucci" <pgollucci@FreeBSD.org>
Message-ID: <20101128151252.GA717@FreeBSD.org>
References: <201011270200.oAR20vwO042200@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <201011270200.oAR20vwO042200@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www Makefile ports/www/py-flask Makefile
	distinfo pkg-descr pkg-plist
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 28 Nov 2010 15:12:52 -0000

On Sat, Nov 27, 2010 at 02:00:57AM +0000, Philip M. Gollucci wrote:
> pgollucci    2010-11-27 02:00:57 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     www                  Makefile 
>   Added files:
>     www/py-flask         Makefile distinfo pkg-descr pkg-plist 
>   Log:
>   Flask is a microframework for Python based on Werkzeug and Jinja 2.
>   
>   WWW:    http://flask.pocoo.org/
>   
>   PR:             ports/151625
>   Submitted by:   Olivier Duchateau <duchateau.olivier at gmail.com>

Ugh, I think I've reviewed this submission, but it still was committed
with lots of bugs:

- PORTNAME should be `flask', not `Flask'
- Makefile header is severely badly indented (and if you wanted to use
 `Flask', that's the right place, instead of `py-flask' which merely
  mimics the port directory name)
- Missing leading tab in the second line of RUN_DEPENDS
- LICENSE should be placed after COMMENT
- In port description, tab after WWW: should be space
- COMMENT should start with capital letter

Also, port description is very scarse; right now it merely repeats the
COMMENT, while it should give some extensive information so that people
should not have to visit the website to find out what is this port for
and about.

Please fix, thanks.

./danfe