From owner-cvs-src@FreeBSD.ORG  Thu May  8 06:52:05 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 50DF337B401; Thu,  8 May 2003 06:52:05 -0700 (PDT)
Received: from cognet.ci0.org (cognet.ci0.org [80.65.224.102])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C867743F85; Thu,  8 May 2003 06:52:03 -0700 (PDT)
	(envelope-from doginou@cognet.ci0.org)
Received: from cognet.ci0.org (localhost [127.0.0.1])
	by cognet.ci0.org (8.12.9/8.12.9) with ESMTP id h48DoqlS088326;
	Thu, 8 May 2003 15:50:53 +0200 (CEST)
	(envelope-from doginou@cognet.ci0.org)
Received: (from doginou@localhost)
	by cognet.ci0.org (8.12.9/8.12.9/Submit) id h48Doqqa088325;
	Thu, 8 May 2003 15:50:52 +0200 (CEST)
Date: Thu, 8 May 2003 15:50:51 +0200
From: Olivier Houchard <cognet@ci0.org>
To: Nate Lawson <nate@root.org>
Message-ID: <20030508135051.GA75992@ci0.org>
References: <20030506020032.8318437B478@hub.freebsd.org>
	<20030506133223.V29676@root.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030506133223.V29676@root.org>
User-Agent: Mutt/1.5.4i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/pci if_sis.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 May 2003 13:52:06 -0000

On Tue, May 06, 2003 at 01:57:47PM -0700, Nate Lawson wrote:
> > @@ -1374,8 +1374,6 @@
> >  		goto fail;
> >  	}
> >
> > -	callout_handle_init(&sc->sis_stat_ch);
> > -
> >  	/*
> >  	 * Call MI attach routine.
> >  	 */
> 
> I would rather you deleted the first call to callout_handle_init() instead
> (after the "Inform the world" comment).  Reasons include poor style for
> the first one and uniformity with other sys/pci/if_* drivers which do the
> init right before ether_ifattach().
> 

I don't have any objection in this being changed.

> > @@ -1747,8 +1745,6 @@
> >  		if (ifp->if_snd.ifq_head != NULL)
> >  			sis_start(ifp);
> >  	}
> > -
> > -	sc->sis_stat_ch = timeout(sis_tick, sc, hz);
> >
> >  	SIS_UNLOCK(sc);
> >
> 
> Can you check the other sys/pci/if_* devices to see if they have the same
> bug?  I think they all re-add the timeout at the end of *_tick().
> 

The problem was really that mii_tick() called sis_miibus_statchg() which
calls sis_init() which attempts to remove the timeout (but fails at this moment
because it is not PENDING) and then re-add the timeout. 
I checked all the other if_* files and didn't find any similar scenario.

> -Nate

Olivier