From owner-svn-src-all@FreeBSD.ORG Wed Mar 9 06:01:33 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86D94106564A; Wed, 9 Mar 2011 06:01:33 +0000 (UTC) (envelope-from dchagin@dchagin.static.corbina.ru) Received: from contrabass.post.ru (contrabass.post.ru [85.21.78.5]) by mx1.freebsd.org (Postfix) with ESMTP id 2F7B08FC12; Wed, 9 Mar 2011 06:01:32 +0000 (UTC) Received: from corbina.ru (mail.post.ru [195.14.50.16]) by contrabass.post.ru (Postfix) with ESMTP id 71CACCC4D4; Wed, 9 Mar 2011 09:01:29 +0300 (MSK) X-Virus-Scanned: by cgpav Uf39PSi9pFi9oFi9 Received: from [10.208.22.99] (HELO dchagin.static.corbina.ru) by corbina.ru (CommuniGate Pro SMTP 5.1.14) with ESMTPS id 306765802; Wed, 09 Mar 2011 09:01:29 +0300 Received: from dchagin.static.corbina.ru (localhost [127.0.0.1]) by dchagin.static.corbina.ru (8.14.4/8.14.4) with ESMTP id p2961SFn004131; Wed, 9 Mar 2011 09:01:28 +0300 (MSK) (envelope-from dchagin@dchagin.static.corbina.ru) Received: (from dchagin@localhost) by dchagin.static.corbina.ru (8.14.4/8.14.4/Submit) id p2961NTB004130; Wed, 9 Mar 2011 09:01:23 +0300 (MSK) (envelope-from dchagin) Date: Wed, 9 Mar 2011 09:01:23 +0300 From: Chagin Dmitry To: John Baldwin Message-ID: <20110309060123.GA4088@dchagin.static.corbina.ru> References: <201103081901.p28J1jjh083821@svn.freebsd.org> <201103081627.37026.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sdtB3X0nJg68CQEu" Content-Disposition: inline In-Reply-To: <201103081627.37026.jhb@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r219405 - in head/sys: amd64/amd64 amd64/linux32 arm/arm compat/ia32 compat/linux compat/svr4 i386/i386 i386/ibcs2 i386/linux ia64/ia64 kern mips/mips powerpc/powerpc sparc64/sparc64 sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2011 06:01:33 -0000 --sdtB3X0nJg68CQEu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 08, 2011 at 04:27:36PM -0500, John Baldwin wrote: > On Tuesday, March 08, 2011 2:01:45 pm Dmitry Chagin wrote: > > Author: dchagin > > Date: Tue Mar 8 19:01:45 2011 > > New Revision: 219405 > > URL: http://svn.freebsd.org/changeset/base/219405 > >=20 > > Log: > > Extend struct sysvec with new method sv_schedtail, which is used for = an > > explicit process at fork trampoline path instead of eventhadler(sched= tail) > > invocation for each child process. > > =20 > > Remove eventhandler(schedtail) code and change linux ABI to use newly= added > > sysvec method. > > =20 > > While here replace explicit comparing of module sysentvec structure w= ith the > > newly created process sysentvec to detect the linux ABI. > > =20 > > Discussed with: kib > > =20 > > MFC after: 2 Week > >=20 > > Modified: head/sys/compat/linux/linux_emul.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/compat/linux/linux_emul.c Tue Mar 8 18:39:41 2011 (r21940= 4) > > +++ head/sys/compat/linux/linux_emul.c Tue Mar 8 19:01:45 2011 (r21940= 5) > > @@ -300,13 +300,16 @@ linux_proc_exec(void *arg __unused, stru > > } > > =20 > > void > > -linux_schedtail(void *arg __unused, struct proc *p) > > +linux_schedtail(struct thread *td) > > { > > struct linux_emuldata *em; > > + struct proc *p; > > int error =3D 0; > > int *child_set_tid; > > =20 > > - if (__predict_true(p->p_sysent !=3D &elf_linux_sysvec)) > > + p =3D td->td_proc; > > + > > + if (SV_PROC_ABI(p) !=3D SV_ABI_LINUX) > > return; >=20 > Isn't this always false now? >=20 Indeed, even a bit funny. fixed, thanks!! --=20 Have fun! chd --sdtB3X0nJg68CQEu Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iEYEARECAAYFAk13F7MACgkQ0t2Tb3OO/O3p9QCeJK/F9I43jMxC2vZwTVDsyrLj E9YAoMfdhgjpbGYv63l3I1Jtu/UD1CsH =bajL -----END PGP SIGNATURE----- --sdtB3X0nJg68CQEu--