From owner-freebsd-current Fri Apr 19 21:43:15 2002 Delivered-To: freebsd-current@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id C585B37B41D; Fri, 19 Apr 2002 21:43:11 -0700 (PDT) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.2/8.12.2) with ESMTP id g3K4h7iJ001156; Sat, 20 Apr 2002 08:43:10 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.3/8.12.2/Submit) id g3K4h7o7001155; Sat, 20 Apr 2002 08:43:07 +0400 (MSD) Date: Sat, 20 Apr 2002 08:43:06 +0400 From: "Andrey A. Chernov" To: current@FreeBSD.ORG, green@FreeBSD.ORG Subject: Re: SSH: LOGIN_CAP limits & ~/.login.conf not processed now Message-ID: <20020420044306.GA1132@nagual.pp.ru> References: <20020420012140.GA66589@nagual.pp.ru> <20020420024304.GA95425@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020420024304.GA95425@nagual.pp.ru> User-Agent: Mutt/1.3.28i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Apr 20, 2002 at 06:43:05 +0400, Andrey A. Chernov wrote: > On Sat, Apr 20, 2002 at 05:21:42 +0400, Andrey A. Chernov wrote: > > Well, who damages LOGIN_CAP processing in sshd now? It not reads > > ~/.login_conf anymore and not sets LOGIN_CAP limits. > > I see parent environment seriously damaged in do_setusercontext() since > not saved. I mean MAIL,BLOCKSIZE & FTP_PASSIVE_MODE variables, > overwritten by /etc/login.conf Really any environment variable can be > overwritten here, so please restore good old code which saves&restores > parent environment before calling setusercontext(). do_setup_env() code is > broken too because call setusercontext() which modify _current_ > environment, and NOT child one. NOTE: I just commit the fix, see session.c commit log for detailed explanation. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message