From owner-svn-src-head@FreeBSD.ORG Wed May 22 03:43:50 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E983CE06 for ; Wed, 22 May 2013 03:43:50 +0000 (UTC) (envelope-from mailer-daemon@vniz.net) Received: from mail-la0-x233.google.com (mail-la0-x233.google.com [IPv6:2a00:1450:4010:c03::233]) by mx1.freebsd.org (Postfix) with ESMTP id 77C325E3 for ; Wed, 22 May 2013 03:43:50 +0000 (UTC) Received: by mail-la0-f51.google.com with SMTP id lx15so1442084lab.24 for ; Tue, 21 May 2013 20:43:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:openpgp:content-type :content-transfer-encoding:x-gm-message-state; bh=FNeXZjLhopoYR2I6by0FvzCthBdW5X9OvXqdCvPpLnY=; b=i8HzaEHbqTtIEAdKDlhfgxInH9mHVEDL9NZGS5p9qZYjOPOWAsSfakX/H1tO6pzvl6 T1pcCMuTqm7/pvQVo36N6E10C6xO+uagboywRXPwpmb+Y/h4v3uQRoa2itzpLno4Njjt 8gu0T2srjkPI1FLJBDz1p2p5tnUogXrdZeyVZB2gYHdLIiadyCDA5j3UnALRnKx19Btw W/m9lRPhCZhl58cHI4UjIxt3x9mMXSWqF9wUuTrkQK//LigDOX170E2xl9fMhU7EF3s+ ffXP/1FcMArsurU3Uwlf25QiU1Q959ERusgTFY7wQ1TC/ZpqHDS3GAyyj11mq/Wj0le8 S2cw== X-Received: by 10.112.218.39 with SMTP id pd7mr3058490lbc.13.1369194229288; Tue, 21 May 2013 20:43:49 -0700 (PDT) Received: from [192.168.1.2] ([89.169.163.3]) by mx.google.com with ESMTPSA id c5sm2160655lbe.1.2013.05.21.20.43.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 May 2013 20:43:48 -0700 (PDT) Message-ID: <519C3EE7.1000800@freebsd.org> Date: Wed, 22 May 2013 07:43:35 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Ed Schouten Subject: Re: svn commit: r250883 - in head: include include/xlocale lib/libc/locale sys/sys tools/regression/lib/libc/locale References: <201305211959.r4LJxbLx034714@svn.freebsd.org> <20130521220003.GB58299@stack.nl> In-Reply-To: OpenPGP: id=964474DD Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Gm-Message-State: ALoCoQnkuxvdDZIJ3X6zTs393lvivK0GT2yyVlktjJUNbqpcjblAotuZwLKpUtWk9/CT9ZF8gtfm Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Jilles Tjoelker X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2013 03:43:51 -0000 On 22.05.2013 2:20, Ed Schouten wrote: > 2013/5/22 Jilles Tjoelker : >> Our wchar_t is only ISO 10646 for UTF-8 and possibly US-ASCII and >> ISO8859-1 (subset) locales. > > Oh, the horror! I thought on FreeBSD, we used the LC_CTYPE files to do > a mapping to ISO 10646. Unfortunately, it seems to be the case that > these files are only used to do mappings to > uppercase/lowercase/runetype. Bummer. > > I'll see what I can do to fix this. I'll likely implement something > like you suggested, that we return EILSEQ if the locale is not ASCII, > ISO8859-1 or UTF-8. Yes, non UTF-8 and its subsets locales are not encoded in ISO 10646 internally but have their own internal encoding. Returning EILSEQ will broke them all at once, so I see no point to add new functions such way, because GNU configure will sense them, and then they doesn't work. Proper way is ether to not add them or use lib/libc/iconv for them (adding a lot of missing locales into lib/libiconv_modules). -- http://ache.vniz.net/ bitcoin:13fGiNutKNHcVSsgtGQ7bQ5kgUKgEQHn7N