From owner-freebsd-bugs  Thu Nov 22  3:10:23 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id B938B37B418
	for <freebsd-bugs@hub.freebsd.org>; Thu, 22 Nov 2001 03:10:00 -0800 (PST)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id fAMBA0o36812;
	Thu, 22 Nov 2001 03:10:00 -0800 (PST)
	(envelope-from gnats)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id DB84C37B405
	for <freebsd-gnats-submit@FreeBSD.org>; Thu, 22 Nov 2001 03:05:56 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id fAMB5uF36346;
	Thu, 22 Nov 2001 03:05:56 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200111221105.fAMB5uF36346@freefall.freebsd.org>
Date: Thu, 22 Nov 2001 03:05:56 -0800 (PST)
From: WATANABE Yuichi <yuu-w@ascii.co.jp>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-1.0
Subject: bin/32183: lpd problem.
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         32183
>Category:       bin
>Synopsis:       lpd problem.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Nov 22 03:10:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     WATANABE Yuichi
>Release:        FreeBSD 4.4R
>Organization:
ASCII Corp.
>Environment:
FreeBSD oapc13.oa.ascii.co.jp 4.4-RELEASE FreeBSD 4.4-RELEASE #0: Wed Sep 26 16:55:13 JST 2001     root@oapc13.oa.ascii.co.jp:/usr/src/sys/compile/PRTSVR00  i386
>Description:
if
 1) lpd received printing-job request from remote-cliant
and
 2) target-printe is busy
then
 some messages are in /var/log/messages, /var/log/lpd-errs

 lpd[nnnn]: Error receiving job from hostname.com:
 lpd[nnnn]: prt01: ctl_renametf invalid filename: tfB521hostname.com

I made comparison source program of 4.4R with 3.4R.

/usr/src/usr.sbin/lpr/lpd/recvjob.c
 readjob(pp)
 @ case '\2':      /* read cf file */

In the 3.4R,
-----
 if (link(tfname, cp) < 0)
        frecverr("%s: %m", tfname);
 (void) unlink(tfname);
 tfname[0] = '\0';
-----
In the 4.4R
-----
 tfname[0] = '\0';
 if (errmsg != NULL) {
    frecverr("%s: %s", pp->printer, errmsg);
     /*NOTREACHED*/
  /* (void) unlink(tfname); */         /* need !? */
 }
-----

>How-To-Repeat:

>Fix:

>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message