From owner-dev-commits-src-all@freebsd.org Sun Jan 3 05:09:16 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D00A14C591F; Sun, 3 Jan 2021 05:09:16 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D7myN5T0gz4R2k; Sun, 3 Jan 2021 05:09:16 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-ot1-f50.google.com with SMTP id d8so23113555otq.6; Sat, 02 Jan 2021 21:09:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qv5S04Td8BkH4QZpT+i1GUehh8hWUAhMMoiPtcr6FNc=; b=cPt+ZSDaXOnCosD34TwAbQJa29B6YB/1Zy+yiGJR68BM9x6lSBUu+lXGvxE1meA2w4 Ks1NRJqzpr7Ioaa43E0cNMLSydFIArDy2Q9nTszsKwCq8+TUZz6S21kO4XwyrVgTJgPk nc+08N8xXuGnEY/TwJEkCYuwwhfrVp8hyxaopwd4Gqu73DcHgAignzpMwJWAM0UIhuP3 WQ1H/ZyoMOyR7vibSHuF11yzi3tErf5vtVk4m9m4D4mr4LRWfIv5LucsPW/Nd5x+4zgV nhWfy6aIpdZMzQXpJaqZXmDp5RIu0atIZHL50dDJG0wyaVnsaGfK2n9dBW4gcKeLSunE 0CCQ== X-Gm-Message-State: AOAM531rn4lOjy1iWsw5T9ocDSXGYaoKHDSpNVFEyXFypnLoxUMysMZY c1dGlR7xO08R+/SLeA4ZBU8s1TWyjW/XsLmQDqcneAL+iMU= X-Google-Smtp-Source: ABdhPJyV9QRfUGr6tUdgQrOcTAoqhJ8mpa8WCsNsCyGiNaaJpy/IWd6d/c/LySDgFN5MhGnoyu0Q7lKooQT/ALTbJ44= X-Received: by 2002:a05:6830:2413:: with SMTP id j19mr50938351ots.251.1609650555421; Sat, 02 Jan 2021 21:09:15 -0800 (PST) MIME-Version: 1.0 References: <202101030259.1032x5hV006606@gitrepo.freebsd.org> In-Reply-To: From: Alan Somers Date: Sat, 2 Jan 2021 22:09:04 -0700 Message-ID: Subject: Re: git: 022ca2fc7fe0 - main - Add aio_writev and aio_readv To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" X-Rspamd-Queue-Id: 4D7myN5T0gz4R2k X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2021 05:09:16 -0000 On Sat, Jan 2, 2021 at 9:39 PM Jessica Clarke wrote: > On 3 Jan 2021, at 02:59, Alan Somers wrote: > > diff --git a/sys/kern/syscalls.master b/sys/kern/syscalls.master > > index b7ea5e939635..aaa0a1277461 100644 > > --- a/sys/kern/syscalls.master > > +++ b/sys/kern/syscalls.master > > @@ -1477,7 +1477,17 @@ > > _In_opt_ struct sigevent *sig > > ); > > } > > -258-271 AUE_NULL UNIMPL nosys > > +258 AUE_AIO_WRITEV STD { > > + int aio_writev( > > + _Inout_ struct aiocb *aiocbp > > + ); > > + } > > +259 AUE_AIO_READV STD { > > + int aio_readv( > > + _Inout_ struct aiocb *aiocbp > > + ); > > + } > > +260-271 AUE_NULL UNIMPL nosys > > 272 AUE_O_GETDENTS COMPAT11 { > > int getdents( > > int fd, > > Should these not be added to the end? > > Jess > Should they be? I'm not aware of any requirement to add new syscalls to the end. I put them here so they would be next to the other AIO syscalls.