From owner-svn-src-head@freebsd.org Tue Jul 19 21:22:39 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25660B9EE43 for ; Tue, 19 Jul 2016 21:22:39 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm18-vm0.bullet.mail.bf1.yahoo.com (nm18-vm0.bullet.mail.bf1.yahoo.com [98.139.213.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CA7AD16D9 for ; Tue, 19 Jul 2016 21:22:38 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1468963350; bh=LbMhfiZVPIPTqKi5gWy6Tm6HEmPKqxE5aidTGIQUNSc=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=SuhjVNInYNml1vQVPWhsSMxd3lvpc1dUeSMCEO70HmkReGqk8qds1NZIL1o4YhiCDJtDuK77kLnh/oUe7QuRbprIBENjRPlhvnyItcXms9xY0H+psMq9lg6xD6AiILHqvjclp07xhNquuSgXGYsBPVsSNdX307E7nRSYlSLruy/Nu2YTzJmpCrGEYJH0y4IbXxPFuh1hgdV7ZE/tP6qfzFC4N//w5NSIQtOI2szh9F0WXOHljol6N33l07hXDeRqjmyH46CKEbu0x3BWUBiC/xAOuqdUXWjEQIJmTOJQR76gra5oZX6DassuzDeMjGwnShEZ3ROunR5qvXrhWV8K6A== Received: from [98.139.170.181] by nm18.bullet.mail.bf1.yahoo.com with NNFMP; 19 Jul 2016 21:22:30 -0000 Received: from [98.139.211.194] by tm24.bullet.mail.bf1.yahoo.com with NNFMP; 19 Jul 2016 21:22:30 -0000 Received: from [127.0.0.1] by smtp203.mail.bf1.yahoo.com with NNFMP; 19 Jul 2016 21:22:30 -0000 X-Yahoo-Newman-Id: 870474.29954.bm@smtp203.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: Ff.odvsVM1l6UaWimbtRRuTdayr.Xpa6SxGgpUf9nJJIFH_ p7M53a1dwP3h8qNojmYWy1uzNoCKdsYLMUKrEolib3G4.JIqvMlhZKdftqD2 mqOjZJH98fXMCZlfFl_J.MDH6AEIVS0DT_yzz_00E3q2HjR6QIRrwyFbsfEG Xm8C7X7XP44L1qESrCTePZUOXmQKuVtpqF0XsZ1Byh.0QxGyx1YFlclc3hcf 3_34SehGLvA4wLVQch.hj5uWSYnP17ZlzyLUejkSShiyuW.kGQrW9ySJUbUz lF1HXaK0FjNwUKUvndTlLeRykK4w.Fa3OixLL3PhD4McyDE6ZE0WDclEhA4W 4Tpy4gekaRI4hrRC7JoKRS5u8uoDzF8obt7KG9JPkY6ZxMRpxvysg_vJLtaM 1gNGz5VfWGgAPqIsXfVNDkg4SOe04ExwUdRRF8zbROd2fgw7351eyhhzp29F uxBnDCt2VpHh0Ni._KkLcM9GnQ0fMaLxiql.07ZK5zYySX6qMtdG4mtoUB.R 8ZJpjt9ztB5qBaAQlFg7ahnro0wwwAc2gkoMApoNjAV3TfA-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r303046 - head/lib/libc/locale To: Ed Schouten References: <201607192022.u6JKMDJD051361@repo.freebsd.org> Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Pedro Giffuni Message-ID: <0273c74d-fc3b-8bf9-9c79-8bc8101943dc@FreeBSD.org> Date: Tue, 19 Jul 2016 16:22:33 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2016 21:22:39 -0000 Hi; On 07/19/16 15:46, Ed Schouten wrote: > Hi Pedro, > > 2016-07-19 22:22 GMT+02:00 Pedro F. Giffuni : >> Author: pfg >> Date: Tue Jul 19 20:22:13 2016 >> New Revision: 303046 >> URL: https://svnweb.freebsd.org/changeset/base/303046 >> >> Log: >> libc: tag the Rune initialization function prototypes visibility as hidden. > > How does this interact with symbol versioning/mapping? Wouldn't our C > library's symbol map already make these symbols hidden without any > explicit annotation? > It shouldn't hurt at all, this is not the first use that we make of the visibility attributes in libc. I do notice we tend to put them at the end of the prototype, while I followed the Apple notation of setting them in front. No idea if that is worthwhile to change. It is true that these symbols should already be hidden but in the case some port is using -fvisibility= compiler flag this will prevent the symbols from getting exported by accident. Pedro.