From owner-freebsd-current@FreeBSD.ORG Wed Mar 11 00:46:45 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 06BF0106566B for ; Wed, 11 Mar 2009 00:46:45 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from gizmo.2hip.net (gizmo.2hip.net [64.74.207.195]) by mx1.freebsd.org (Postfix) with ESMTP id BEF9D8FC12 for ; Wed, 11 Mar 2009 00:46:44 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from [192.168.1.156] (adsl-157-60-27.bna.bellsouth.net [70.157.60.27]) (authenticated bits=0) by gizmo.2hip.net (8.14.3/8.14.3) with ESMTP id n2B0jKW6012755 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 10 Mar 2009 20:45:21 -0400 (EDT) (envelope-from rnoland@FreeBSD.org) From: Robert Noland To: pyunyh@gmail.com In-Reply-To: <20090311003244.GA13527@michelle.cdnetworks.co.kr> References: <200903101425.28608.jhb@freebsd.org> <200903101637.31039.jhb@freebsd.org> <1236728841.2091.5.camel@balrog.2hip.net> <20090311003244.GA13527@michelle.cdnetworks.co.kr> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-h8I33M6Qjt9zIonvqbSY" Organization: FreeBSD Date: Tue, 10 Mar 2009 19:46:22 -0500 Message-Id: <1236732382.2091.25.camel@balrog.2hip.net> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 FreeBSD GNOME Team Port X-Spam-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_PBL, RDNS_DYNAMIC autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on gizmo.2hip.net Cc: freebsd-current@freebsd.org, "Arno J. Klaassen" Subject: Re: msi broken? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2009 00:46:45 -0000 --=-h8I33M6Qjt9zIonvqbSY Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2009-03-11 at 09:32 +0900, Pyun YongHyeon wrote: > On Tue, Mar 10, 2009 at 06:47:21PM -0500, Robert Noland wrote: > > On Wed, 2009-03-11 at 00:36 +0100, Arno J. Klaassen wrote: > > > John Baldwin writes: > > >=20 > > > > On Tuesday 10 March 2009 3:00:00 pm Arno J. Klaassen wrote: > > > >> John Baldwin writes: > > > >>=20 > > > >> > On Tuesday 10 March 2009 10:08:59 am Arno J. Klaassen wrote: > > > >> >>=20 > > > >> >> Hello, > > > >> >>=20 > > > >> >> when upgrading this morning from a March 1 -current, if_bge > > > >> >> stopped working (and irq256: bge0 not showing up in > > > >> >> vmstat -i ). Setting hw.pci.enable_msi=3D"0" makes it work agai= n. > > > >> > > > > >> > Can you get a verbose dmesg (boot -v) with MSI enabled? > > > > > > > > Ok, so you are getting MSI interrupts assigned and routed ok. Can = you try=20 > > > > disabling the code that sets the INTx_MASK flag in the PCI command = register=20 > > > > in sys/dev/pci/pci.c:pci_setup_intr()? > > >=20 > > > grr : "rid" sure is 1 for the if_bge interrupt. Please tell me which > > > lines of code set the INTx_MASK flag. Thanx, more tomorrow. > >=20 > > if rid is 0, the chip should be using INTx. if rid > 0 then it should > > be using MSI. > >=20 > >=20 > > } > > mte->mte_handlers++; > > } > > #if 0 /* Comment this out/* > > /* Make sure that INTx is disabled if we are using MSI/= MSIX */ > > pci_set_command_bit(dev, child, PCIM_CMD_INTxDIS); > > #endif > > bad: > > if (error) { > > (void)bus_generic_teardown_intr(dev, child, irq= , > > cookie); > > return (error); > >=20 >=20 > If my memory serve me right, some Broadcom controllers reset PCI > configuration registers in bge_reset() so bge(4) restores some > important PCI configuration registers. I didn't check bge(4) code > but it's possible that bge(4) didn't restore MSI enable bit in > bge_reset(). If it is actually issuing a RST, then it should turn off msi and enable INTx, according to the spec. Without looking at the driver, the RST should happen before bus_setup_intr(); robert. > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " --=20 Robert Noland FreeBSD --=-h8I33M6Qjt9zIonvqbSY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEABECAAYFAkm3Cd4ACgkQM4TrQ4qfROPJ3ACfdCtoRwyC925yUUKht9ZQRjRM YQUAoIJxV6q54iEDIceczmQvpkVQhiFw =CXHg -----END PGP SIGNATURE----- --=-h8I33M6Qjt9zIonvqbSY--