From owner-freebsd-commit  Mon Oct 30 02:04:56 1995
Return-Path: owner-commit
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id CAA16115
          for freebsd-commit-outgoing; Mon, 30 Oct 1995 02:04:56 -0800
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id CAA16100
          for cvs-all-outgoing; Mon, 30 Oct 1995 02:04:50 -0800
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id CAA16089
          for cvs-usrbin-outgoing; Mon, 30 Oct 1995 02:04:47 -0800
Received: from tfs.com (tfs.com [140.145.250.1])
          by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id CAA16076
          ; Mon, 30 Oct 1995 02:04:43 -0800
Received: from critter.tfs.com by tfs.com (smail3.1.28.1) with SMTP
	id m0t9qS1-0003wfC; Mon, 30 Oct 95 01:24 PST
Received: from localhost (localhost [127.0.0.1]) by critter.tfs.com (8.6.11/8.6.9) with SMTP id CAA01972; Sat, 28 Oct 1995 02:10:02 +0100
X-Authentication-Warning: critter.tfs.com: Host localhost didn't use HELO protocol
To: Peter Wemm <peter@freebsd.org>
cc: CVS-commiters@freebsd.org, cvs-usrbin@freebsd.org
Subject: Re: cvs commit: src/usr.bin/symorder symorder.c 
In-reply-to: Your message of "Sat, 28 Oct 1995 05:27:21 MST."
             <199510281227.FAA08026@freefall.freebsd.org> 
Date: Sat, 28 Oct 1995 02:10:02 +0100
Message-ID: <1970.814842602@critter.tfs.com>
From: Poul-Henning Kamp <phk@critter.tfs.com>
Sender: owner-commit@freebsd.org
Precedence: bulk

> peter       95/10/28 05:27:21
> 
>   Modified:    usr.bin/symorder  symorder.c
>   Log:
>   symorder appears to have been designed to run on executable files
>   only, as it payes no attention to the relocation table (which
>   references the symbols).
>   
>   As a result, running "symorder -c" to clean up the visibility of a LKM
>   ".o" file (as is done in the new bsd.kmod.mk) totally screws up the
>   relocation table, making the LKM file unloadable. (ld: bogus
>   relocation record)
Darn, I should have thought of that.

>   This is a pretty crude fix - I've changed symorder so that when
>   running in "cleanup" mode, it disables the reordering which was
>   screwing up the relocation table.  I'm sure there is a better fix, but
>   I didn't have the energy.  Feel free to fix this hack, probably by
>   renumbering the symbol indexes in the relocation table.
This is perfectly sensible.  The order of symbols in a .o is completely
insignificant.

Thanks Peter!
--
Poul-Henning Kamp           | phk@FreeBSD.ORG       FreeBSD Core-team.
http://www.freebsd.org/~phk | phk@login.dknet.dk    Private mailbox.
whois: [PHK]                | phk@ref.tfs.com       TRW Financial Systems, Inc.
Future will arrive by its own means, progress not so.