From owner-svn-src-all@freebsd.org Tue Dec 4 09:16:00 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0EFA7132B1B1; Tue, 4 Dec 2018 09:16:00 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AA7066EE1E; Tue, 4 Dec 2018 09:15:59 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 98D73F763; Tue, 4 Dec 2018 09:15:59 +0000 (UTC) Date: Tue, 4 Dec 2018 09:15:59 +0000 From: Alexey Dokuchaev To: Yuri Pankov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r341446 - head/release/amd64 Message-ID: <20181204091559.GA38765@FreeBSD.org> References: <201812032231.wB3MVvaD060931@repo.freebsd.org> <20181204084122.GB94570@FreeBSD.org> <05039715-2792-fdb2-735f-c5842f4d8087@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05039715-2792-fdb2-735f-c5842f4d8087@FreeBSD.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: AA7066EE1E X-Spamd-Result: default: False [0.17 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.01)[-0.010,0]; NEURAL_SPAM_LONG(0.38)[0.380,0]; NEURAL_HAM_SHORT(-0.20)[-0.196,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 09:16:00 -0000 On Tue, Dec 04, 2018 at 11:52:34AM +0300, Yuri Pankov wrote: > Alexey Dokuchaev wrote: > > On Mon, Dec 03, 2018 at 10:31:57PM +0000, Yuri Pankov wrote: > >> New Revision: 341446 > >> URL: https://svnweb.freebsd.org/changeset/base/341446 > >> > >> Log: > >> mkisoimages.sh: don't use -p flag when copying loader.efi to msdosfs. > >> > >> This fixes 'cdrom' target in the case when world was built by user, > >> and not root. > > > > Could you please explain why -p should not have been used here? I fail > > to understand this from the commit log. I've always considered preserving > > various file metadata as a good thing to do, and this commit puzzles me. > > Because the target is on msdosfs, and the only metadata that can be > preserved is modification time which isn't that useful with the file > being hidden in ESP. OTOH, 'cp -p' fails trying to preserve owner/group > if source is not owned by root (as commit message says). Additional > 'chmod' call done in HBSD doesn't do much as well -- it seems we can > only set/unset owner's 'write' flag which corresponds to DOS 'readonly' > attribute. Ah, I see now, so cp(1) was failing and that upset 'set -e'. Thanks for explanation. ./danfe