From owner-cvs-all Mon Jul 1 22:20:58 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 893E437B400; Mon, 1 Jul 2002 22:20:53 -0700 (PDT) Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id A4DB843E0A; Mon, 1 Jul 2002 22:20:50 -0700 (PDT) (envelope-from keramida@ceid.upatras.gr) Received: from hades.hell.gr (patr530-b186.otenet.gr [212.205.244.194]) by mailsrv.otenet.gr (8.12.4/8.12.4) with ESMTP id g625KlQ7026966; Tue, 2 Jul 2002 08:20:48 +0300 (EEST) Received: from hades.hell.gr (hades [127.0.0.1]) by hades.hell.gr (8.12.4/8.12.4) with ESMTP id g625KkXU026720; Tue, 2 Jul 2002 08:20:46 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Received: (from charon@localhost) by hades.hell.gr (8.12.4/8.12.4/Submit) id g625Kk6x026719; Tue, 2 Jul 2002 08:20:46 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Date: Tue, 2 Jul 2002 08:20:45 +0300 From: Giorgos Keramidas To: David Xu Cc: John Polstra , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 in_cksum.c src/sys/i386/include in_cksum.h Message-ID: <20020702052044.GA25618@hades.hell.gr> References: <200207020403.g62434Iv003501@freefall.freebsd.org> <006c01c2217c$e4f49250$ef01a8c0@davidwnt> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <006c01c2217c$e4f49250$ef01a8c0@davidwnt> X-Operating-System: FreeBSD 5.0-CURRENT i386 X-PGP-Fingerprint: C1EB 0653 DB8B A557 3829 00F9 D60F 941A 3186 03B6 X-Phone: +30-944-116520 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 2002-07-02 11:59 +0000, David Xu wrote: > > jdp 2002/07/01 21:03:04 PDT > > > > Modified files: (Branch: RELENG_4) > > sys/i386/i386 in_cksum.c > > sys/i386/include in_cksum.h > > Log: > > MFC: Fixes to asm statements in the Internet checksum code to make > > them safer at high optimization levels. > > Does this mean that we can safely compile kernel with -O2? Well, probably no. But it does mean that -O2 will not cause checksums to fail randomly and cause packets to be dropped because of invalid 0xfffe checksums (as tcpdump reported for me a long time ago, when I was hit by this). To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message