From owner-freebsd-current@FreeBSD.ORG  Sun May 10 17:13:24 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 30216FD1
 for <freebsd-current@freebsd.org>; Sun, 10 May 2015 17:13:24 +0000 (UTC)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E238C13D8
 for <freebsd-current@freebsd.org>; Sun, 10 May 2015 17:13:23 +0000 (UTC)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 0D9B71FE023;
 Sun, 10 May 2015 19:13:22 +0200 (CEST)
Message-ID: <554F91DE.8010209@selasky.org>
Date: Sun, 10 May 2015 19:14:06 +0200
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Oliver Pinter <oliver.pinter@hardenedbsd.org>
CC: Wolfgang Zenker <wolfgang@lyxys.ka.sub.org>, freebsd-current@freebsd.org
Subject: Re: Race VT+X11 on -current
References: <CAN6yY1vno+-nV9zBYp11A=F-vAURbhraEFyQR_ue4W7h8pQUMw@mail.gmail.com>	<AA8B24D1-DF5A-42CD-8755-15EF3C46E760@gmail.com>	<554BC475.50203@selasky.org>	<554BD2A8.70702@selasky.org>	<554C3CCB.3030809@selasky.org>	<4937E44E-C0EF-4052-961C-F46D5EC5BE00@gmail.com>	<554C8AEB.2080502@selasky.org>	<554CC841.60908@freebsd.org>	<20150509210525.GA80848@lyxys.ka.sub.org>	<554F5379.2070100@selasky.org>	<20150510165330.GA86856@lyxys.ka.sub.org>	<554F8BA6.9000702@selasky.org>
 <CAPQ4ffuBNahdwrj6kGustSBk9V3qr1CP+-5__Cp-F2wqbB6=Rg@mail.gmail.com>
In-Reply-To: <CAPQ4ffuBNahdwrj6kGustSBk9V3qr1CP+-5__Cp-F2wqbB6=Rg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 10 May 2015 17:13:24 -0000

On 05/10/15 19:00, Oliver Pinter wrote:
> Hi Hans!
>
> > Hi,
>>
>> Sounds good. I'll MFC the patch sometime next week. Seems like more
>> people need it for daily FreeBSD use :-)
>
> I have this fix or enhancements in our HardenedBSD codebase:
> https://github.com/HardenedBSD/hardenedBSD/commit/18058137da01598403b6ffa40c37b0a907441530
> Please review them, and if you feel this required in FreeBSD too, and
> cherry-pick them.
>

Hi Oliver,

Your patch is correct from what I can see. Signed modulus can be creepy 
sometimes! Better if VT_MAXWINDOWS was power of two and we used a 
bitwise AND.

https://svnweb.freebsd.org/changeset/base/282730

--HPS