From nobody Tue Jan 30 05:39:49 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TPDWn4jFCz58L8C for ; Tue, 30 Jan 2024 05:39:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TPDWn2bfxz4WmK for ; Tue, 30 Jan 2024 05:39:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706593189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lgbVxbasrCU5knHT/qr7hJoYcDkWTDl9wXwxLZgX2ks=; b=NLJEbuKG+hY+oBQHhse4sdV1riDDCa2zXYYs+kxKQ/1iV2BrBbeeoezIyVMSrXxjNsNfLY iPx7cF4XRAzSvy34htHDIFbcuwcWxfcGrCkw6wWL17GUahaQq3sgpYDLvl65wSx3DCyTUn 5183N3QHlYtCiH6LUI1LopLHojYm0frq5dzu0HaccuBUGGgvp79fQz19YFpGh/JRoFtusB WTERaeRNZ1Gcd8Qk73h9tPVHXRak26jP+VO/nASzvpmFvA8ckHzVhHUMogZG8P5oPH+CUR s6Se1t4ElqWUrfjHWifXt8FamAvuCbFz0czt96JARKu4mnGYNE6NWle6VebMBA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706593189; a=rsa-sha256; cv=none; b=m/xQORMHGFe/iJI+R4ssIjXww2ssFDjkEwKWbQXkeGUmf/vDu8vvBsNkcsDvK2fEDKyXgk 2j0HBE1n19jOX8nnZRvTmgx7svhn8/qoglb5ZzKM/KbB/hz+uga6Rrn7NUeLYC+i3kK1k3 KHvR2rF8zCJCdwRghZSk3Yw68SUwwkETv9YOFJ+g6dd5Ug1R1prCb2XZOs0mY7UtvsqL2x 7ZXMpVhQz3TJWeKDoJsHGUkVMfIKe8oG4AFqcjevrqjnpaho9yaC1gpBQTWG9lRSB4xOne sBMDVIqWrxDUZYkK5e1acgrxb/+IYyxXWOmey/2m0iHqhDZQR+wMNPih+4ztXg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4TPDWn1MvWzNYR for ; Tue, 30 Jan 2024 05:39:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 40U5dnUr062748 for ; Tue, 30 Jan 2024 05:39:49 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 40U5dnOS062742 for net@FreeBSD.org; Tue, 30 Jan 2024 05:39:49 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 276392] if_wg: Fix noise_remote_alloc() to acquire 'l_identity_lock' lock Date: Tue, 30 Jan 2024 05:39:49 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kevans@freebsd.org X-Bugzilla-Flags: mfc-stable14? mfc-stable13? mfc-stable12- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276392 --- Comment #7 from commit-hook@FreeBSD.org --- A commit in branch stable/14 references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Db0fa37f356fd9dd5040c034c7523ec235= fbb311b commit b0fa37f356fd9dd5040c034c7523ec235fbb311b Author: Aaron LI AuthorDate: 2024-01-17 23:29:23 +0000 Commit: Kyle Evans CommitDate: 2024-01-30 05:37:33 +0000 if_wg: fix access to noise_local->l_has_identity and l_private These members are protected by the identity lock, so rlock it in noise_remote_alloc() and then assert that we have it held to some extent in noise_precompute_ss(). PR: 276392 (cherry picked from commit 7a4d1d1df0b2e369adcb32aea9ef8c180f885751) sys/dev/wg/wg_noise.c | 4 ++++ 1 file changed, 4 insertions(+) --=20 You are receiving this mail because: You are on the CC list for the bug.=