From owner-dev-commits-src-main@freebsd.org Fri May 7 09:39:48 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E41905FDA1D; Fri, 7 May 2021 09:39:48 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fc55J62qyz3t7K; Fri, 7 May 2021 09:39:48 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: lwhsu/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id BDA673C73; Fri, 7 May 2021 09:39:48 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by mail-yb1-f174.google.com with SMTP id l7so11136596ybf.8; Fri, 07 May 2021 02:39:48 -0700 (PDT) X-Gm-Message-State: AOAM530Y22eAT5+ZyNuhFXHH6JVSzNkvy/xMIQPpyt2Ry2ocFaE+hXvw GIMaiuwwlH4c51cA5NW7Pkvkeram9Oxj9u0OrzQ= X-Google-Smtp-Source: ABdhPJwqeefnpjQKQPe90a/teYt1uwesW1RO8wAOr+3V9cAySI15BV364dRyEJ+RZtbGT9hWgX/IlLWKRiXLGk8Q3Lw= X-Received: by 2002:a25:7a42:: with SMTP id v63mr11843533ybc.497.1620380388241; Fri, 07 May 2021 02:39:48 -0700 (PDT) MIME-Version: 1.0 References: <202105061526.146FQS0E008755@gitrepo.freebsd.org> In-Reply-To: <202105061526.146FQS0E008755@gitrepo.freebsd.org> From: Li-Wen Hsu Date: Fri, 7 May 2021 17:39:37 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 5d8fd932e418 - main - This brings into sync FreeBSD with the netflix versions of rack and bbr. This fixes several breakages (panics) since the tcp_lro code was committed that have been reported. Quite a few new features are now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the largest). There is also support for ack-war prevention. Documents comming soon on rack.. To: Randall Stewart Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 May 2021 09:39:49 -0000 On Thu, May 6, 2021 at 11:26 PM Randall Stewart wrote: > > The branch main has been updated by rrs: > > URL: https://cgit.FreeBSD.org/src/commit/?id=5d8fd932e418f03e98b3469c4088a36f0ef34ffe > > commit 5d8fd932e418f03e98b3469c4088a36f0ef34ffe > Author: Randall Stewart > AuthorDate: 2021-05-06 15:22:26 +0000 > Commit: Randall Stewart > CommitDate: 2021-05-06 15:22:26 +0000 > > This brings into sync FreeBSD with the netflix versions of rack and bbr. > This fixes several breakages (panics) since the tcp_lro code was > committed that have been reported. Quite a few new features are > now in rack (prefecting of DGP -- Dynamic Goodput Pacing among the > largest). There is also support for ack-war prevention. Documents > comming soon on rack.. > > Sponsored by: Netflix > Reviewed by: rscheff, mtuexen > Differential Revision: https://reviews.freebsd.org/D30036 This seems braking LINT kernel build of powerpc: https://ci.freebsd.org/job/FreeBSD-main-powerpc-LINT/6082/console Searching "error:" leads to: 00:08:15.153 /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2143:16: error: implicit declaration of function 'tcp_hw_highest_rate' is invalid in C99 [-Werror,-Wimplicit-function-declaration] 00:08:15.153 high_rate = tcp_hw_highest_rate(rack->r_ctl.crte); 00:08:15.153 ^ and 00:08:15.163 /workspace/src/sys/modules/tcp/rack/../../../netinet/tcp_stacks/rack.c:2165:16: error: implicit declaration of function 'tcp_hw_highest_rate_ifp' is invalid in C99 [-Werror,-Wimplicit-function-declaration] 00:08:15.163 high_rate = tcp_hw_highest_rate_ifp(rack->rc_inp->inp_route.ro_nh->nh_ifp, rack->rc_inp); 00:08:15.163 ^ I suspect this is because RATELIMIT is not defined in default powerpc build? Is it safe to enable it? Best, Li-Wen