From owner-freebsd-current@FreeBSD.ORG Wed Jun 15 20:23:58 2005 Return-Path: X-Original-To: current@FreeBSD.ORG Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 576BB16A41F for ; Wed, 15 Jun 2005 20:23:58 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2FADD43D58 for ; Wed, 15 Jun 2005 20:23:57 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j5FKNtXG015251; Wed, 15 Jun 2005 13:23:55 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j5FKNtkN015250; Wed, 15 Jun 2005 13:23:55 -0700 Date: Wed, 15 Jun 2005 13:23:55 -0700 From: Brooks Davis To: Warner Losh Message-ID: <20050615202355.GA12986@odin.ac.hmc.edu> References: <20050614231344.F76340@mp2.macomnet.net> <20050615.002712.123500387.imp@bsdimp.com> <20050615230844.G61956@mp2.macomnet.net> <20050615.135552.74722719.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mP3DRpeJDSE+ciuQ" Content-Disposition: inline In-Reply-To: <20050615.135552.74722719.imp@bsdimp.com> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu Cc: current@FreeBSD.ORG Subject: Re: ed(4) broken? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2005 20:23:58 -0000 --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 15, 2005 at 01:55:52PM -0600, Warner Losh wrote: > From: Maxim Konovalov > Subject: Re: ed(4) broken? > Date: Wed, 15 Jun 2005 23:14:52 +0400 (MSD) >=20 > > On Wed, 15 Jun 2005, 00:27-0600, M. Warner Losh wrote: > >=20 > > > In message: <20050614231344.F76340@mp2.macomnet.net> > > > Maxim Konovalov writes: > > > : Latest GENERIC in qemu produces > > > : Jun 14 19:12:04 qemu6 kernel: ed_start(0xc12e5000) GONE > > > : Jun 14 19:12:07 qemu6 kernel: ed0: NIC memory corrupt - invalid pac= ket length 45 > > > : No real hardware though. > > > > > > ed works for me on all the real hardware I have. Maybe you could give > > > me more details. > >=20 > > Something between 2005/06/10 00:00 UTC and 2005/06/11 00:00 UTC broke > > qemu's ed(4). I'm still not sure it's not qemu problem. No > > additional info so far, sorry. >=20 > That's when the big, jumbo ifnet patch went in. I eyeballed the > changes and can see nothing wrong by visual inspection. I've looked to code over closely again and I'm supprised it works for anyone. I found four instances of casts of sc to get ifp including one if sc_xmit. I must have missed them when reconverting the driver after your cleanup. :( I've commited a fix for them. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --mP3DRpeJDSE+ciuQ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCsI5aXY6L6fI4GtQRAjUPAKCOFVEqi9gbzY0kG9pcIBvVLDwrJQCfSAcb t93q2fW1q4Huhe8/tq+Ogwc= =5Luw -----END PGP SIGNATURE----- --mP3DRpeJDSE+ciuQ--