From owner-freebsd-current Fri Jan 26 14:14: 7 2001 Delivered-To: freebsd-current@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id A19E637B400 for ; Fri, 26 Jan 2001 14:13:50 -0800 (PST) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id f0QM9T345774; Fri, 26 Jan 2001 14:09:29 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20010126220820.2fa3265a.steveo@eircom.net> Date: Fri, 26 Jan 2001 14:13:42 -0800 (PST) From: John Baldwin To: "Steve O'Hara-Smith" Subject: RE: patch for test: /etc/shells -> /usr/local/etc/shells Cc: current@FreeBSD.org Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 26-Jan-01 Steve O'Hara-Smith wrote: > Hi, > > Following some recent comments on the evil ways of ports have of > writing in /etc on install - This assumes that everyone uses /usr/local for ${LOCALBASE}, which is not a good assumption to make. If you want to do this right, then ports should modify ${LOCALBASE}/etc/shells, and a couple of things should happen: 1) All parsing of /etc/shells should move off into libutil under a suitable API. 2) The implementation of this API should allow for multiple files that it checks. One way might be to add a '.include' keyword or something so that /etc/shells could have '.include /usr/local/etc/shells' that the admin could adjust should he/she choose to change ${LOCALBASE} to something other than /usr/local. This is more work than your patch, but this patch doesn't really solve the problem, it merely moves it. It also breaks for ${LOCALBASE} != /usr/local, so I don't think it should go in. My $.02. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message