From owner-cvs-etc Tue Jul 30 01:00:26 1996 Return-Path: owner-cvs-etc Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id BAA28163 for cvs-etc-outgoing; Tue, 30 Jul 1996 01:00:26 -0700 (PDT) Received: from silvia.HIP.Berkeley.EDU (silvia.HIP.Berkeley.EDU [136.152.64.181]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id BAA28121; Tue, 30 Jul 1996 01:00:09 -0700 (PDT) Received: (from asami@localhost) by silvia.HIP.Berkeley.EDU (8.7.5/8.6.9) id BAA03486; Tue, 30 Jul 1996 01:00:00 -0700 (PDT) Date: Tue, 30 Jul 1996 01:00:00 -0700 (PDT) Message-Id: <199607300800.BAA03486@silvia.HIP.Berkeley.EDU> To: jkh@time.cdrom.com CC: bde@zeta.org.au, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-etc@freefall.freebsd.org, jkh@freefall.freebsd.org In-reply-to: <12099.838712874@time.cdrom.com> (jkh@time.cdrom.com) Subject: Re: cvs commit: src/etc rc From: asami@cs.berkeley.edu (Satoshi Asami) Sender: owner-cvs-etc@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk * I personally prefer my variable expansions to be *always* bracketed, * whether they need it lexically or not, simply because it causes the * variable names to stand out better in the text. * * Jordan * * > * the test is actually "X${foo}" != X"NO". The braces mainly waste space. * > ^^^^^^^^^^^^^^^^^^ * > This is quite inconsistent itself, shouldn't it be * > * > X"$foo" != X"NO" * > * > or * > * > "X$foo" != "XNO" My comment wasn't on curly braces. Please look at the quotes carefully. Actually, as Bruce says, not quoting the XNO at all is probably the best idea. Satoshi