From owner-svn-src-all@FreeBSD.ORG Mon Mar 26 21:22:52 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 96294106566C; Mon, 26 Mar 2012 21:22:52 +0000 (UTC) (envelope-from gonzo@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 80DB68FC14; Mon, 26 Mar 2012 21:22:52 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q2QLMqtT050711; Mon, 26 Mar 2012 21:22:52 GMT (envelope-from gonzo@svn.freebsd.org) Received: (from gonzo@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id q2QLMqbl050709; Mon, 26 Mar 2012 21:22:52 GMT (envelope-from gonzo@svn.freebsd.org) Message-Id: <201203262122.q2QLMqbl050709@svn.freebsd.org> From: Oleksandr Tymoshenko Date: Mon, 26 Mar 2012 21:22:52 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r233521 - head/sys/cddl/dev/dtrace X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Mar 2012 21:22:52 -0000 Author: gonzo Date: Mon Mar 26 21:22:51 2012 New Revision: 233521 URL: http://svn.freebsd.org/changeset/base/233521 Log: Properly cast 64-bit dofhp_dof to pointer. For i386 this change is no-op. For AMD64 it was tested with DTrace test suite: results are the same from the test run before the change and after Modified: head/sys/cddl/dev/dtrace/dtrace_ioctl.c Modified: head/sys/cddl/dev/dtrace/dtrace_ioctl.c ============================================================================== --- head/sys/cddl/dev/dtrace/dtrace_ioctl.c Mon Mar 26 19:23:57 2012 (r233520) +++ head/sys/cddl/dev/dtrace/dtrace_ioctl.c Mon Mar 26 21:22:51 2012 (r233521) @@ -39,11 +39,7 @@ dtrace_ioctl_helper(struct cdev *dev, u_ case DTRACEHIOC_ADDDOF: dhp = (dof_helper_t *)addr; /* XXX all because dofhp_dof is 64 bit */ -#ifdef __i386 - addr = (caddr_t)(uint32_t)dhp->dofhp_dof; -#else - addr = (caddr_t)dhp->dofhp_dof; -#endif + addr = (caddr_t)(vm_offset_t)dhp->dofhp_dof; /* FALLTHROUGH */ case DTRACEHIOC_ADD: dof = dtrace_dof_copyin((intptr_t)addr, &rval);