From owner-freebsd-xen@FreeBSD.ORG  Mon Jan 17 10:52:28 2011
Return-Path: <owner-freebsd-xen@FreeBSD.ORG>
Delivered-To: freebsd-xen@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A165D1065693
	for <freebsd-xen@freebsd.org>; Mon, 17 Jan 2011 10:52:28 +0000 (UTC)
	(envelope-from got.andras@deployis.eu)
Received: from mail.deployis.eu (mail.deployis.eu [217.20.135.253])
	by mx1.freebsd.org (Postfix) with ESMTP id 584788FC08
	for <freebsd-xen@freebsd.org>; Mon, 17 Jan 2011 10:52:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deployis.eu;
	s=default; 
	h=Subject:To:From:Date; bh=arO3zECshnfbrkao3HWVNRuxRCT4TGHMm8LDmhs2oww=;
	b=ihbwO1py23QlprqAqVnmvf2J5hkr275n3wEbCQvLVVVVKWGUOqaaGbfK07kFVMN/vpmIAVt6E94eaCbs5JohNVbye7Z5y0nautfll9Y5n6vKwYObEaLP8xWlkLWPTIwE;
Received: from [80.95.75.131] (port=38206 helo=[192.168.2.194])
	by mail.deployis.eu with esmtpsa (Exim 4.71 #1 (Debian))
	id 1PemhH-0004HU-45
	from <got.andras@deployis.eu>; Mon, 17 Jan 2011 11:52:27 +0100
Message-ID: <4D341F6A.2010804@deployis.eu>
Date: Mon, 17 Jan 2011 11:52:26 +0100
From: =?ISO-8859-1?Q?G=F3t_Andr=E1s?= <got.andras@deployis.eu>
User-Agent: Thunderbird 2.0.0.24 (X11/20101027)
MIME-Version: 1.0
To: Janne Snabb <snabb@epipe.com>
References: <alpine.BSF.2.00.1101150731240.20212@tiktik.epipe.com>	<alpine.BSF.2.00.1101151002450.20212@tiktik.epipe.com>	<alpine.BSF.2.00.1101171018400.20212@tiktik.epipe.com>
	<alpine.BSF.2.00.1101171026200.20212@tiktik.epipe.com>
In-Reply-To: <alpine.BSF.2.00.1101171026200.20212@tiktik.epipe.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-DKIM-Status: None (from 80.95.75.131)
X-Mail-Status-postahivatal: trustedmail (from 80.95.75.131)
Cc: freebsd-xen@freebsd.org
Subject: Re: xn0: Error 2 parsing device/vif/0/mac [PATCH]
X-BeenThere: freebsd-xen@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion of the freebsd port to xen - implementation and usage
	<freebsd-xen.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-xen>,
	<mailto:freebsd-xen-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-xen>
List-Post: <mailto:freebsd-xen@freebsd.org>
List-Help: <mailto:freebsd-xen-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-xen>,
	<mailto:freebsd-xen-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Jan 2011 10:52:28 -0000

I'll give it a try today or later tomorrow with AMD and Xeon machines 
with Xen 3.4.3. I hope Colin can also make this for 8.2 release, if 
these are fine.



Janne Snabb wrote:
> On Mon, 17 Jan 2011, Janne Snabb wrote:
> 
>> This patch might be a bit neater.
> 
> Oops, bug. A bracket at the wrong place. This one should be better.
> 
> Sorry about the noise,
> --
> Janne Snabb / EPIPE Communications
> snabb@epipe.com - http://epipe.com/
> 
> 
> --- sys/dev/xen/netfront/netfront.c.orig	2010-12-21 17:09:25.000000000 +0000
> +++ sys/dev/xen/netfront/netfront.c	2011-01-17 10:11:06.000000000 +0000
> @@ -401,13 +401,14 @@
>  xen_net_read_mac(device_t dev, uint8_t mac[])
>  {
>  	int error, i;
>  	char *s, *e, *macstr;
>  
> -	error = xs_read(XST_NIL, xenbus_get_node(dev), "mac", NULL,
> -	    (void **) &macstr);
> -	if (error)
> +	if ((error = xs_read(XST_NIL, xenbus_get_node(dev), "mac", NULL,
> +	    (void **) &macstr)) != 0 &&
> +	    (error = xs_read(XST_NIL, xenbus_get_otherend_path(dev), 
> +	    "mac", NULL, (void **) &macstr)) != 0)
>  		return (error);
>  
>  	s = macstr;
>  	for (i = 0; i < ETHER_ADDR_LEN; i++) {
>  		mac[i] = strtoul(s, &e, 16);
> _______________________________________________
> freebsd-xen@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-xen
> To unsubscribe, send any mail to "freebsd-xen-unsubscribe@freebsd.org"