Date: Thu, 22 Sep 2011 20:52:31 +0200 From: Emanuel Haupt <ehaupt@critical.ch> To: Doug Barton <dougb@FreeBSD.org> Cc: "cvs-all@FreeBSD.org" <cvs-all@FreeBSD.org>, "cvs-ports@FreeBSD.org" <cvs-ports@FreeBSD.org>, Peter Jeremy <peterjeremy@acm.org>, Emanuel Haupt <ehaupt@FreeBSD.org>, "ports-committers@FreeBSD.org" <ports-committers@FreeBSD.org> Subject: Re: cvs commit: ports/x11/xterm Makefile pkg-plist Message-ID: <21BC4480-6954-47F2-A5DA-F6F920CF9637@critical.ch> In-Reply-To: <4E7A437A.5030401@FreeBSD.org> References: <201103100949.p2A9nOO8057627@repoman.freebsd.org> <20110919234126.GA82010@server.vk2pj.dyndns.org> <20110921115818.2878356b.ehaupt@FreeBSD.org> <4E7A23D3.5070509@FreeBSD.org> <20110921210838.893ad8f0.ehaupt@FreeBSD.org> <4E7A437A.5030401@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21.09.2011, at 22:05, Doug Barton <dougb@FreeBSD.org> wrote: > On 09/21/2011 12:08, Emanuel Haupt wrote: >> Doug Barton <dougb@FreeBSD.org> wrote: >>> On 09/21/2011 02:58, Emanuel Haupt wrote: >>>> Peter Jeremy <peterjeremy@acm.org> wrote: >>> >>>>> This is a bit belated but why does xterm need a hard dependency >>>>> on gnome? Could you please look at making this optional so that >>>>> those of us who don't run bloatware can turn it off. >>>> >>>> Good point. I've just committed a patch that makes the installation >>>> of desktop entries conditional. >>> >>> What isn't clear to me is why the installation of the desktop entry >>> depends on gnome at all. Why not just install the file? I ask because >>> (at least) xfce also uses the desktop entries, so having them is >>> useful for non-gnome cases as well. >> >> From what I understand "desktopfileutils" needs to be set in (USE| >> WANT)_GNOME if there are *.desktop files installed. This is where some >> gnome dependencies are pulled in. > > Yes, I understand that this is your understanding, otherwise you > wouldn't have done it that way. :) I am attempting to challenge that > understanding. IOW, can the installation of the desktop file be split > out from the gnome desktopfileutils part? > > The attached works for the non-gnome case, and the xterm.desktop file > appears as expected for xfce. Looks good. Feel free to commit, I am currently afk. Emanuel > > > Doug > > -- > > Nothin' ever doesn't change, but nothin' changes much. > -- OK Go > > Breadth of IT experience, and depth of knowledge in the DNS. > Yours for the right price. :) http://SupersetSolutions.com/ > > <xterm-desktop.diff>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?21BC4480-6954-47F2-A5DA-F6F920CF9637>