From owner-freebsd-arch@FreeBSD.ORG Mon Nov 7 22:52:02 2005 Return-Path: X-Original-To: freebsd-arch@freebsd.org Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 903E616A420 for ; Mon, 7 Nov 2005 22:52:02 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail5.speedfactory.net [66.23.216.218]) by mx1.FreeBSD.org (Postfix) with ESMTP id 443D343DBA for ; Mon, 7 Nov 2005 22:51:49 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 1544755 for multiple; Mon, 07 Nov 2005 17:53:43 -0500 Received: from localhost.baldwin.cx (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id jA7MpX4p019534; Mon, 7 Nov 2005 17:51:35 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Mon, 7 Nov 2005 17:51:31 -0500 User-Agent: KMail/1.8.2 References: <20051106222359.GC46752@stack.nl> <200511071635.39323.jhb@freebsd.org> <436FD47D.2000802@samsco.org> In-Reply-To: <436FD47D.2000802@samsco.org> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200511071751.32609.jhb@freebsd.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: Rink Springer , ed@fxq.nl, freebsd-arch@freebsd.org Subject: Re: FreeBSD/xbox: updated 7.0 patchset X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2005 22:52:02 -0000 On Monday 07 November 2005 05:26 pm, Scott Long wrote: > John Baldwin wrote: > > On Monday 07 November 2005 02:44 pm, Rink Springer wrote: > >>Hi, > >> > >>OK, I've updated the patchset. Changes: > >> > >>- opt_xbox.h is now used instead of opt_global.h > >>- xboxfb.c should follow style(9) better > >>- boot_font.c is no longer patched > >>- 128MB XBOX-es should work too [1] > >> > >>It is fetchable from > >>http://rink.nu/downloads/xbox-patches/xbox-7-current.v2.diff > >> > >>Oh, and for John's comment: The reason pic16l.s is coded in assembly, was > >>that it was used extensively while debugging (it even resided in > >>locore.s for a while :-), as being able to change the LED's color is > >>immensely useful if you don't have a framebuffer working already :) This > >>is why I'd prefer to keep this file as-is. > > > > You do realize that you can call C functions from assembly, right? :) > > If this is the only remaining technical objection, then can it be > something that gets resolved after it goes into the tree? It's code > that is segregated and private to the XBOX port, so it would be a shame > to make it stall this great work. Yes, certainly, that is only a minor nit! I just tend to prefer that we keep as much code in C as possible rather than asm as C has a lower learning curve. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org