From owner-freebsd-current  Fri Jan  3 10:17:20 2003
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3CCB137B401; Fri,  3 Jan 2003 10:17:19 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E585143E4A; Fri,  3 Jan 2003 10:17:17 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id FAA11661;
	Sat, 4 Jan 2003 05:17:13 +1100
Date: Sat, 4 Jan 2003 05:17:23 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: phk@FreeBSD.ORG
Cc: Takahashi Yoshihiro <nyan@jp.FreeBSD.org>, <current@FreeBSD.ORG>
Subject: Re: buildworld trouble: multiple struct dos_partition. 
In-Reply-To: <26833.1041612576@critter.freebsd.dk>
Message-ID: <20030104043358.K4900-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Fri, 3 Jan 2003 phk@FreeBSD.ORG wrote:

> In message <20030104.011305.74720364.nyan@jp.FreeBSD.org>, Takahashi Yoshihiro
> writes:
> >In article <10926.1041590588@critter.freebsd.dk>
> >Poul-Henning Kamp <phk@freebsd.org> writes:
> >
> >> I think you need to either #ifdef something here (and there may be
> >> more some similar code in places like truss or the debugger) or
> >> alternatively rename the structure to "pc98_partition" or similar.
> >
> >I think that the name "dos_partition" is not suitable for both i386
> >and pc98.  I wonder what does "dos" mean here.  For example, it should
> >be renamed to "mbr_partition" for i386 and "pc98_partition" for pc98,
> >respectively.
>
> You are correct in principle.

"pc98_partition" is OK, but "mbr_partition" is bogus since partition tables
are not restricted to the MBR -- there is one in every extended partition.

<sys/diskpc98.h> is similarly OK and <sys/diskmbr.h> is similarly bogus.

"at386" would be a better prefix/suffix than "mbr" for the non-pc98 pc's.
It is used for the main bus space header.

The normal prefix for "partition table" seems to be "" according to google.
FreeBSD has "dos_partition" and NetBSD has "mbr_partition".

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message