From nobody Fri May 3 07:47:40 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VW2vw6Yvwz5JWVv for ; Fri, 3 May 2024 07:47:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VW2vw4J2dz4JvZ for ; Fri, 3 May 2024 07:47:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714722460; a=rsa-sha256; cv=none; b=JUeOv4fETTXX+d64q0RIzEJgfp7W3cTauU2OpAh0Erjq348I/tzSN5Xdz97lkjwYMImeYY N1nXKoaPf3b5jUQAAqS82fWfFqhJlnzEWbMoayy2M7qz9qpzCD5M4QH9Fb4DLituPYY/DT Gd2PtrWr4MhRtqwBbznPQF3QUrGYl5psa2fRguqT2ytydu9Y71vwYuOJ02DlL/UVfsGmfT RO+TSmSwjwfdGtGVglw97rAHBtTa1WrGl/Z+h6KDNut/qO8zX9P4VdYpVwqv21d7wWtBB/ EgnS71t1mRSjyK6nEjCYP9MhZxmBSxwwsR2XggNxzq1YnkNBeBvBsYpEnAMamw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714722460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9k3WvVMvb9f5ziyDWjXLLoQ//UjnxsG62lfID1eXSks=; b=IJII2gRrWMFFImkhrtEF5sbl3Puxs+OBJm5Fat++b69hIdr01WQvsTR+5+YoNVpkUk6U+F FS8qkMVrO3Nuzt2FmqCTsaEA71cWKjhvdPQdvyK4YZHWWzIJEeFbnP+c2wj0ti6Erjz4b+ DtIcLrVjzFGLDvrvW8Mbgsa/7NjXIWnTAeWwAObXjb7T3r09i4GxSuAlTRduTp6gL6fyqt sRvZS7rrRNA8/S+S1lbr5ruhoJ1EDX863oQi6pTPyuID1tqFnkfUQ0rUvY76uTbCoxg0cH ZLQ7to+yBLVj3r1EQUk2tpVSLCpz4oyY9BkQHf56OJjnvDXLEm/TIUVMaQ8uWA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VW2vw3nzTzchB for ; Fri, 3 May 2024 07:47:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4437leqB008110 for ; Fri, 3 May 2024 07:47:40 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4437leb6008108 for ports-bugs@FreeBSD.org; Fri, 3 May 2024 07:47:40 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 267384] Make Mk/Scripts/do-users-groups.sh fail-fast instead of silently succeeding Date: Fri, 03 May 2024 07:47:40 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: michaelo@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267384 --- Comment #10 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D4280a82efe69f5dc77a67394f7bd360= 95c74cd6c commit 4280a82efe69f5dc77a67394f7bd36095c74cd6c Author: Michael Osipov AuthorDate: 2023-11-22 11:30:32 +0000 Commit: Michael Osipov CommitDate: 2024-05-03 07:44:53 +0000 Mk/Scripts/do-users-groups.sh: Make users and groups creation fail-fast Fail fast when pw(8) fails to create a user or a group. Especially when= it is not the last command in the pre-install script then the exit code will = be 0 and the failure will go unnoticed. PR: 267384 Approved by: jrm (mentor) Differential Revision: https://reviews.freebsd.org/D42719 Mk/Scripts/do-users-groups.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=