From owner-cvs-all Tue Jan 16 22:30:19 2001 Delivered-To: cvs-all@freebsd.org Received: from sydney.worldwide.lemis.com (unknown [129.94.172.186]) by hub.freebsd.org (Postfix) with ESMTP id 19C0C37B400; Tue, 16 Jan 2001 22:29:50 -0800 (PST) Received: (from grog@localhost) by sydney.worldwide.lemis.com (8.11.1/8.9.3) id f0H0Lgi06964; Wed, 17 Jan 2001 10:51:42 +1030 (CST) (envelope-from grog) Date: Wed, 17 Jan 2001 10:51:42 +1030 From: Greg Lehey To: Bruce Evans , Brian Somers Cc: Sheldon Hearn , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, bde@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/vinum vinumio.c Message-ID: <20010117105142.A6918@sydney.worldwide.lemis.com> References: <200101162215.f0GMFQB94292@hak.lan.Awfulhak.org> <200101140633.f0E6XAB16846@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: ; from bde@zeta.org.au on Sun, Jan 14, 2001 at 10:04:20PM +1100 Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tuesday, 16 January 2001 at 22:15:26 +0000, Brian Somers wrote: >> On Monday, 15 January 2001 at 9:15:28 +0200, Sheldon Hearn wrote: >>> >>> >>> On Sat, 13 Jan 2001 22:33:10 PST, Greg Lehey wrote: >>> >>>> Break some long format strings so that they fit in style(9)-sized >>>> lines. >>> >>> Last time I did that, bde complained that this was a bug in style(9). >> >> He didn't put it that way this time. >> >>> Are we happy now that broken format strings are better than overlong >>> lines? >> >> No, he complained again. I'll revert that stuff. > > I would tend to believe that splitting the format string is the > better way to go. What's the advantage with not splitting ? Well, you should ask Bruce, not me. Here's the reasoning: On Sunday, 14 January 2001 at 22:04:20 +1100, Bruce Evans wrote: >> Modified files: >> sys/dev/vinum vinumio.c >> Log: >> ... >> Break some long format strings so that they fit in style(9)-sized >> lines. > > This is a style bug. I have fixed it in a few places, e.g.: > > --- > RCS file: /home/ncvs/src/sys/netinet/tcp_input.c,v > Working file: tcp_input.c > head: 1.121 > ... > ---------------------------- > revision 1.67 > date: 1997/12/19 23:46:15; author: bde; state: Exp; lines: +5 -5 > Don't use ANSI string concatenation to misformat a string. > ---------------------------- > --- > >> Remove some "outdentation". > > Strings to be printed should fit in 80 columns, and using ANSI string > concatenation make it especially hard to see that they fit. Outdenting > gives the best chance. In fact, at least the first string obfuscated > in this commit has Buckley's chance of fitting, since it it longer than > 80 even before all the %'s are converted. > > Bruce Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message