From owner-freebsd-current@FreeBSD.ORG Fri Dec 23 00:12:37 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 78B9016A41F for ; Fri, 23 Dec 2005 00:12:37 +0000 (GMT) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3366143D5D for ; Fri, 23 Dec 2005 00:12:22 +0000 (GMT) (envelope-from sam@errno.com) Received: from [10.0.0.198] ([10.0.0.198]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id jBN0CKiE032825 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Dec 2005 16:12:21 -0800 (PST) (envelope-from sam@errno.com) Message-ID: <43AB4126.8020004@errno.com> Date: Thu, 22 Dec 2005 16:13:26 -0800 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0.7 (X11/20051207) X-Accept-Language: en-us, en MIME-Version: 1.0 To: jdelano@nspiral.com References: <20051222151654.487394aa30c155c9a20129fbf28b1b35.82098b0558.wbe@email.email.secureserver.net> In-Reply-To: <20051222151654.487394aa30c155c9a20129fbf28b1b35.82098b0558.wbe@email.email.secureserver.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@freebsd.org Subject: Re: ieee80211_input.c - typo? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2005 00:12:37 -0000 jdelano@nspiral.com wrote: > Hi Sam, > > Build with new patch for ath failed because of line 713 below > > > *** src/sys/net80211/ieee80211_input.c Sun Dec 18 10:24:27 2005 > --- /usr/src/sys/net80211/ieee80211_input.c Thu Dec 22 05:41:23 2005 > *************** > *** 710,716 **** > if (m != NULL) { > if (ni->ni_vlan != 0) { > /* attach vlan tag */ > ! VLAN_INPUT_TAG(ifp, m, ni->ni_vlan); /* <<<<< missing comma ? */ > if (m == NULL) > goto out; /* XXX goto err? */ > } > --- 710,716 ---- > if (m != NULL) { > if (ni->ni_vlan != 0) { > /* attach vlan tag */ > ! VLAN_INPUT_TAG(ifp, m, ni->ni_vlan,); > if (m == NULL) > goto out; /* XXX goto err? */ > } > The vlan code changed; you'll need to fix the output of the patch. Not sure when I'll have time to update it. Sam