From owner-svn-src-all@FreeBSD.ORG Tue Nov 11 17:47:44 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6A2D77D7 for ; Tue, 11 Nov 2014 17:47:44 +0000 (UTC) Received: from mail-lb0-f176.google.com (mail-lb0-f176.google.com [209.85.217.176]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DF560EB2 for ; Tue, 11 Nov 2014 17:47:43 +0000 (UTC) Received: by mail-lb0-f176.google.com with SMTP id 10so7889371lbg.21 for ; Tue, 11 Nov 2014 09:47:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=/JZORMLLN9BcuaXVj0lsb5OhW2d4r65MSnTpMTrGBrc=; b=Hgk096RLoGsoCskJHB9Sl9idsWVmZOSH5ZurhYmIk7bx/4+DVifbCfH+utctCJ+P9H vM2hs3jvYhWjaKAA96Z3gl+8QLOCPrMx9ohYyeXOscWVF0lFYkRjK27XtjBg/7Bv0KDe tLmXJQWJPwJID/abCOGe9iBHnTEUInEqR8bmXjxSGlaK2girYD+2uZ/93de3p+afdYKI ORNXoS/mQKWIo3ksphrigBdTMOb6xP0bWSpUBsli+KXBPNXnabVJ/CoCSAgVebljEyRr UawKBg2FOhp29eQhD4u8gxGc4e+KaV3AxSUgLfqXZ7ecGAJsOdWxgT88rKcfjWnECGbA PDCQ== X-Gm-Message-State: ALoCoQkQ59MCa+yxh/b5oNxtw8np8vE5W5OZ9DEcTKZ0sVOPBbiK5fPQxEM4Yo2V/oxAWfnQcAzH X-Received: by 10.112.136.164 with SMTP id qb4mr37781587lbb.62.1415728061408; Tue, 11 Nov 2014 09:47:41 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by mx.google.com with ESMTPSA id rd3sm3691570lbc.27.2014.11.11.09.47.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Nov 2014 09:47:40 -0800 (PST) Message-ID: <54624BBC.3070006@freebsd.org> Date: Tue, 11 Nov 2014 20:47:40 +0300 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: John Baldwin Subject: Re: svn commit: r274365 - head/contrib/tzcode/stdtime References: <201411110407.sAB47gBT003976@svn.freebsd.org> <920BE50C-2DBA-4DCE-BFAB-ACFC11C5A09E@gmail.com> <54623400.1080407@freebsd.org> <201411111134.52984.jhb@freebsd.org> In-Reply-To: <201411111134.52984.jhb@freebsd.org> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Garrett Cooper , Garrett Cooper X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Nov 2014 17:47:44 -0000 On 11.11.2014 19:34, John Baldwin wrote: > On Tuesday, November 11, 2014 11:06:24 am Andrey Chernov wrote: >> On 11.11.2014 18:34, Garrett Cooper wrote: >>>> This code is wrong in any case, setting EOVERFLOW even in unneeded >>>> no-error cases like breaking from the loop. See how NetBSD does it >>>> correctly instead. >>> >>> Hi! >>> I saw your reply earlier but hadn't gotten an opportunity to revise > the patch like you suggested. I'll look at the NetBSD code and see if I can > adapt it to our copy of tzcode. >>> Thank you! >>> >> >> Currently as we need only EOVERFLOW parts from it, I don't think it will >> be hard task to merge only them. > > Do you know if it is fixed upstream? I want to import newer tzcode from > upstream to get implementations of the extensions to allow use of arbitrary > time zones (mktime_z, etc.) > If you mean https://github.com/eggert/tz some NetBSD fixes, including part of EOVERFLOW fixes are merged there by Christos Zoulas reports, see the history in https://github.com/eggert/tz/commits/master/localtime.c But not all of them, NetBSD have more places with EOVERFLOW set (still missing in upstream). F.e. time2sub EOVERFLOW checks are not merged yet. BTW, latest NetBSD version claims that they merge 2014i tz code, so have mktime_z, etc too. -- http://ache.vniz.net/