From owner-cvs-all@FreeBSD.ORG Mon Sep 19 18:43:11 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9BBAB16A41F; Mon, 19 Sep 2005 18:43:11 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 579CF43D46; Mon, 19 Sep 2005 18:43:11 +0000 (GMT) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j8JIhBN6065001; Mon, 19 Sep 2005 18:43:11 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j8JIhBrG065000; Mon, 19 Sep 2005 18:43:11 GMT (envelope-from cperciva) Message-Id: <200509191843.j8JIhBrG065000@repoman.freebsd.org> From: Colin Percival Date: Mon, 19 Sep 2005 18:43:11 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/lib/libpam/modules/pam_exec pam_exec.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2005 18:43:11 -0000 cperciva 2005-09-19 18:43:11 UTC FreeBSD src repository Modified files: lib/libpam/modules/pam_exec pam_exec.c Log: When (re)allocating space for an array of pointers to char, use sizeof(*list), not sizeof(**list). (i.e., sizeof(pointer) rather than sizeof(char)). It is possible that this buffer overflow is exploitable, but it was added after RELENG_5 forked and hasn't been MFCed, so this will not receive an advisory. Submitted by: Vitezslav Novy MFC after: 1 day Revision Changes Path 1.5 +1 -1 src/lib/libpam/modules/pam_exec/pam_exec.c