From nobody Wed Feb 9 23:19:13 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4B4DC19ACCED for ; Wed, 9 Feb 2022 23:19:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JvG6S72d1z4TX1 for ; Wed, 9 Feb 2022 23:19:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A68091615E for ; Wed, 9 Feb 2022 23:19:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 219NJC3x089240 for ; Wed, 9 Feb 2022 23:19:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 219NJCvK089239 for bugs@FreeBSD.org; Wed, 9 Feb 2022 23:19:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 261291] ESX NFS4.1 client hangs, server never responds to EXCHANGE_ID/CREATE_SESSION Date: Wed, 09 Feb 2022 23:19:13 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644448753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M5trBtLbqlu4dVORnGRqgYz0guq+G5dB1JiIh1zZYoI=; b=djCkYk6t+48AEBHocURvojGkGT9pPWFFrmmDADtNa1fWsxrepKny73YQSYaNT3udZG+dF0 mgrRNrI7B/Dyhd9wlLjFhOXRJHcwUV0QZx+AxkYZ1XT2gaaGY8LIeMUx0zBMzQ/Yjed+eC epLShoCoe/tQJzhSVkk5zT4z6PXAn+g0Vgz7cPIMtit2DGk3BHGg9pO7ZQKu1bSI8zyhyR KpeH+O2/zWL0tjIpTxkf5TVz9CsaRDkk/ZKL55jfhs+ezvw0wK8y5jnn3uQ9qY0/Cb/x0v cg4OqWRzWQNvVRweJSJJd63tEj11XlzVKvmLAqeFEe1kOBR7adkFLS5cGHTsnQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644448753; a=rsa-sha256; cv=none; b=ZYdacyNSRiW8w0nsx70QxuNZ7gm8T8lxisV77nvhvRFo6P8na16lttp7oBZT1mJBE/0j2+ HSdRxQuyTtmMokU1enscmwixQqRlJHVYshtPL/uAdw90uQ36myan49Wn9A4/9n7QFjUfeH 376A8YTcboCnba5lgar0d86dZ6rrLL3PMHkg6hVEOFY5ADxXpy4HCCPcCH59RFLmeszh+k kG7OG4pMNMlzYz9q7A5eOHf4I6izSJ9j0GKs4H8VCHHitFf07mAxB+zDinHX2mEwrI4nOe bouTbFHRDk7WoCK1o5gYiLkxlH3H/agRBc+3EJRBpjZTjh2PzI+dkoGNUf/GAQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261291 --- Comment #18 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D17a56f3fabdfacb62f6d8858643cdb186= 1c8c1b5 commit 17a56f3fabdfacb62f6d8858643cdb1861c8c1b5 Author: Rick Macklem AuthorDate: 2022-02-09 23:17:50 +0000 Commit: Rick Macklem CommitDate: 2022-02-09 23:17:50 +0000 nfsd: Reply NFSERR_SEQMISORDERED for bogus seqid argument The ESXi NFSv4.1 client bogusly sends the wrong value for the csa_sequence argument for a Create_session operation. RFC8881 requires this value to be the same as the sequence reply from the ExchangeID operation most recently done for the client ID. Without this patch, the server replies NFSERR_STALECLIENTID, which is the correct response for an NFSv4.0 SetClientIDConfirm but is not the correct error for NFSv4.1/4.2, which is specified as NFSERR_SEQMISORDERED in RFC8881. This patch fixes this. This change does not fix the issue reported in the PR, where the ESXi client loops, attempting ExchangeID/Create_session repeatedly. Reported by: asomers Tested by: asomers PR: 261291 MFC after: 1 week sys/fs/nfsserver/nfs_nfsdstate.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=