From owner-svn-src-head@freebsd.org Fri Apr 28 05:26:30 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 969FDD543A7; Fri, 28 Apr 2017 05:26:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FA2E7E3; Fri, 28 Apr 2017 05:26:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x244.google.com with SMTP id v1so3626825pgv.3; Thu, 27 Apr 2017 22:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=+EKRDsI70V4LDZDoaDY75p0hUunAbrFZ/MQbMgaOtoM=; b=Urn4YD2MQRARYamg2UVHq3XIfvEi2pTgRxqZNIaWt3ndqKmqZrh8oKMN1X0E0lKyZa 07MRRYMJKj9fIKzxu5yIAan/8PEGHTukqI4QenaxgGlvcw+1G3iUYBnzCks4mHS253ba yM7Vpogqf4j+ZbAgPfr46/ZfNOV5ZX+sCELYbyEjsC7aw1bWBHfcxGPmTVO5SwE/HTp7 Rt7RssTPQuHC0d/J9fqXbS8UqlldiBDeEM9/DBvADVs2phfh6cmZf2fPNaFYWlRm8y33 GR2DUmYLmArEAy2Y9mlDcIJ+nBlF4C6WdeU7d1s/gNAEO4rwHlp3s8tyxxY11UOqjOt9 B/3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=+EKRDsI70V4LDZDoaDY75p0hUunAbrFZ/MQbMgaOtoM=; b=spMiYgS5jxb98/F5sM10iwcOuxfNafI+BFS8993TMwlQLHszz+jxMJUbx3cSmwA11R xGSRw5LPeQPHVsnWJX22XleDcZjdLeAIxcUYPwOFyrCQr4PLdfMUCCMOwvnX/p0a+bvj Xx9ue9I/Mft5fqwMV6VJ2SxpL59daJ7XzTml1NVPYRDDntgzsLkMtjhb2styM7duye2b hw5Jqzj9qSQuA4vP3dFtHZn+SiQ1bKADJ/Ove9y6sSdbVeG37S7Z6Fmv5/t+U4IMG6iZ +xzZUzg7pfLyQvIaY2dyDcT5BOD9vIyKB1jPxOD8Hh7npEccftR8eLGHBt3oa8wKz7wN ivRQ== X-Gm-Message-State: AN3rC/5IYyOH+VAeYEbmj+AM6SM3dyA7VDK6X9FMXwlgtvGWJCybJ+yt nleD55zxrLTGhoZrld0= X-Received: by 10.84.231.136 with SMTP id g8mr12405198plk.12.1493357189665; Thu, 27 Apr 2017 22:26:29 -0700 (PDT) Received: from [192.168.50.91] (50-251-209-113-static.hfc.comcastbusiness.net. [50.251.209.113]) by smtp.gmail.com with ESMTPSA id m24sm7965836pfi.129.2017.04.27.22.26.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Apr 2017 22:26:29 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r317543 - head/usr.sbin/bhyve From: Ngie Cooper X-Mailer: iPhone Mail (14E304) In-Reply-To: <201704280513.v3S5DRYU067517@repo.freebsd.org> Date: Thu, 27 Apr 2017 22:26:28 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201704280513.v3S5DRYU067517@repo.freebsd.org> To: Gleb Smirnoff X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 05:26:30 -0000 > On Apr 27, 2017, at 22:13, Gleb Smirnoff wrote: >=20 > Author: glebius > Date: Fri Apr 28 05:13:27 2017 > New Revision: 317543 > URL: https://svnweb.freebsd.org/changeset/base/317543 >=20 > Log: > When no "rfb" configuration specified bind to the default VNC > port instead of binding to a random one. >=20 > Modified: > head/usr.sbin/bhyve/pci_fbuf.c >=20 > Modified: head/usr.sbin/bhyve/pci_fbuf.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/usr.sbin/bhyve/pci_fbuf.c Fri Apr 28 05:09:51 2017 (r317542= ) > +++ head/usr.sbin/bhyve/pci_fbuf.c Fri Apr 28 05:13:27 2017 (r317543= ) > @@ -365,6 +365,8 @@ pci_fbuf_init(struct vmctx *ctx, struct=20 >=20 > sc->fsc_pi =3D pi; >=20 > + sc->rfb_port =3D 5900; > + Wouldn't it be better to use getservbyname? > error =3D pci_fbuf_parse_opts(sc, opts); > if (error !=3D 0) > goto done; >=20