From owner-cvs-all Wed Jun 20 16: 5:37 2001 Delivered-To: cvs-all@freebsd.org Received: from technokratis.com (modemcable052.174-202-24.mtl.mc.videotron.ca [24.202.174.52]) by hub.freebsd.org (Postfix) with ESMTP id E648D37B408; Wed, 20 Jun 2001 16:05:29 -0700 (PDT) (envelope-from bmilekic@technokratis.com) Received: (from bmilekic@localhost) by technokratis.com (8.11.3/8.11.3) id f5KN6gD37032; Wed, 20 Jun 2001 19:06:42 -0400 (EDT) (envelope-from bmilekic) Date: Wed, 20 Jun 2001 19:06:42 -0400 From: Bosko Milekic To: Jordan Hubbard Cc: bright@sneakerz.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/lge if_lge.c src/sys/dev/nge if_nge.c src/sys/dev/vx if_vx.c src/sys/kern uipc_mbuf.c src/sys/pci if_dc.c if_rl.c if_sf.c if_sis.c if_sk.c if_vr.c if_wb.c Message-ID: <20010620190642.A36898@technokratis.com> References: <20010620162727.K4543@sneakerz.org> <20010620174149.A36453@technokratis.com> <20010620170145.N4543@sneakerz.org> <20010620151043X.jkh@osd.bsdi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010620151043X.jkh@osd.bsdi.com>; from jkh@osd.bsdi.com on Wed, Jun 20, 2001 at 03:10:43PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Jun 20, 2001 at 03:10:43PM -0700, Jordan Hubbard wrote: > To be fair to Bosko, what it looks like he's saying is that there's no > reason to pass _any_ value to it since only zero is allowed and it > doesn't do anything different if you pass a difference value. That > would mean that people *can't* "rely on m_devget doing the wrong > thing" because m_devget is currently capable of doing only one thing, > regardless of what you pass to it, in any case. First of all, let me clarify by saying that none of our present code, -CURRENT and -STABLE included, passes anything other than 0 as the `offset' argument to m_devget() prior to this change. And if there is third-party code doing that, then it is likely doing it for the wrong reason. The code that may have required the `offset' argument as it was prior to this change has been ripped out from FreeBSD long ago. The NetBSD guys have it documented: /* * If 'off' is non-zero, packet is trailer-encapsulated, so we have * to skip the type and length fields. */ As jlemon pointed out, related code has been ripped out and we'll never see users for this code. If someone is using the `off' argument, they're not getting what they paid for and probably have a broken driver. So yeah, only 0 is allowed because anything non-zero has insignificant effects. > - Jordan -- Bosko Milekic bmilekic@technokratis.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message