From owner-freebsd-gnome@freebsd.org Fri Feb 26 11:01:25 2021 Return-Path: Delivered-To: freebsd-gnome@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7B39A55D663 for ; Fri, 26 Feb 2021 11:01:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dn6Cn2shLz3PZx for ; Fri, 26 Feb 2021 11:01:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 6262555D984; Fri, 26 Feb 2021 11:01:25 +0000 (UTC) Delivered-To: gnome@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 622B755D6DF for ; Fri, 26 Feb 2021 11:01:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dn6Cn2JRCz3PNJ for ; Fri, 26 Feb 2021 11:01:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 422531808 for ; Fri, 26 Feb 2021 11:01:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 11QB1PjI077723 for ; Fri, 26 Feb 2021 11:01:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 11QB1PWi077722 for gnome@FreeBSD.org; Fri, 26 Feb 2021 11:01:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-feedback requested: [Bug 253870] devel/libgtop: fails to build on head after commit 2bfd8992c7c7 Date: Fri, 26 Feb 2021 11:01:25 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: gnome@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 11:01:25 -0000 Bugzilla Automation has asked freebsd-gnome (Nobody) for maintainer-feedback: Bug 253870: devel/libgtop: fails to build on head after commit 2bfd8992c7c7 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D253870 --- Description --- After updating to a recent head I noticed libgtop failing, with error at the end of this message. The mentioned commit add the bool return type to the inmem function. I noticed this bool type is defined in sys/types.h, but only if _KERNEL is defined. So the first time it is included _KERNEL needs to be defined. I'm trying to get a patch to that effect, but until now I've always been missing some previous inclusion. I'll followup with it as soon as I have a working patch. In file included from procmap.c:54: In file included from /usr/include/ufs/ufs/inode.h:50: /usr/include/sys/buf.h:569:1: error: unknown type name 'bool' bool inmem(struct vnode *, daddr_t); ^ procmap.c:101:25: warning: unused variable 'um' [-Wunused-variable] struct ufsmount um; ^ procmap.c:405:16: warning: cast from 'gchar *' (aka 'char *') to 'glibtop_map_entry *' (aka 'struct _glibtop_map_entry *') increases required alignment from 1 to 8 [-Wcast-align] return (glibtop_map_entry*) g_array_free(maps, FALSE); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings and 1 error generated. gmake[4]: *** [Makefile:573: procmap.lo] Error 1 gmake[4]: *** Waiting for unfinished jobs....