Date: Sat, 7 Jul 2012 10:01:02 -0700 From: Kevin Oberman <kob6558@gmail.com> To: Hiroshi Nishida <nishidafmly@aol.com> Cc: ports@freebsd.org Subject: Re: Fix for broken net-im/libjingle Message-ID: <CAN6yY1t_wcdvgpbWZnWz6OqfG%2BTkMHkUbfmY3DgQDGTeAMCHTA@mail.gmail.com> In-Reply-To: <4FF61A56.3090804@aol.com> References: <4FF61A56.3090804@aol.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 5, 2012 at 3:51 PM, Hiroshi Nishida <nishidafmly@aol.com> wrote: > Hi, > > net-im/libjingle is now marked as BROKEN for non i386 systems. > The attached file is a patch for fixing it. > The compilation error with the original source code is caused by "size_t != > unsigned int" (on non i386). > So, just casting a parameter works. Hiroshi-san, Thanks for spotting this and providing a fix, but just sending mail to ports@ is not a good way to get it committed. It is far too likely to be missed by anyone who can check it out, confirm the fix, and commit it. Could you submit it as a PR? You can either use the bug submission form at http://www.freebsd.org/send-pr.html or use the send-pr command on a FreeBSD system. That will enter it in the FreeBSD bug tracking system and, while it may not be acted on quickly, it will not get lost and, when one of the overworked ports team gets a chance, it will get processed. Thanks so much for spotting this problem and submitting the patch. -- R. Kevin Oberman, Network Engineer E-mail: kob6558@gmail.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAN6yY1t_wcdvgpbWZnWz6OqfG%2BTkMHkUbfmY3DgQDGTeAMCHTA>