From owner-svn-src-head@FreeBSD.ORG Tue Nov 26 16:26:23 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 148DFAD5; Tue, 26 Nov 2013 16:26:23 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id E3AA82AF6; Tue, 26 Nov 2013 16:26:21 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA16302; Tue, 26 Nov 2013 18:26:19 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1VlLSs-0001Jh-Sl; Tue, 26 Nov 2013 18:26:18 +0200 Message-ID: <5294CB73.7030704@FreeBSD.org> Date: Tue, 26 Nov 2013 18:25:23 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Steven Hartland , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r258632 - in head: cddl/contrib/opensolaris/cmd/ztest cddl/contrib/opensolaris/lib/libzpool/common/sys sys/cddl/compat/opensolaris/sys sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys... References: <201311260957.rAQ9vF6d004168@svn.freebsd.org> <5294A0CD.8030000@FreeBSD.org> <54A7475886594221ABD007A86649441D@multiplay.co.uk> In-Reply-To: <54A7475886594221ABD007A86649441D@multiplay.co.uk> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Nov 2013 16:26:23 -0000 on 26/11/2013 18:18 Steven Hartland said the following: > ----- Original Message ----- From: "Andriy Gapon" > > >> on 26/11/2013 14:34 Steven Hartland said the following: >>> Can I ask why choose priority now for TRIM, does this not change the flow of >>> free requests quite significantly? >> >> Sorry, I couldn't grok the question... >> Also, please take into account that I know nothing about TRIM nor TRIM + ZFS. >> >> BTW, I appreciate the review but a timely review[*] would be appreciated even >> more :-) > > Erm did I miss something, this only got commited a few hours ago which is > the first I knew about it. Did you ask for reviews somewhere I'm not aware of? Did you trim too much of my reply? There was a "footnote" with a reference. >>> Also as we have rotational information available should we apply >>> the following change which makes the active queue timestamp sorted >>> instead of offset sorted? >>> >>> An AVL as a FIFO queue seems like quite an expensive option. >> >> I've just merged the upstream change, perhaps badly. >> Any improvement are appreciated. > > Will look in more depth at this one as it touches the mirror code I commited > recently. Thank you! -- Andriy Gapon