From owner-svn-src-all@freebsd.org Tue Sep 20 04:19:05 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7340FBDF990 for ; Tue, 20 Sep 2016 04:19:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3BD0D84E for ; Tue, 20 Sep 2016 04:19:05 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x232.google.com with SMTP id m79so8277454ioo.3 for ; Mon, 19 Sep 2016 21:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=17c8XpxOUV6PMKBGkT6hgRc9wmj0RfqUb4n9M0h3sFA=; b=WBfwtyTkSHv6Q8sqmJeMQKYHCXNR++0IcjNquJrpXX+7+pzO1lP6OtIDIT3TXB+JJu vHaYJB0y8+te4+VgEeoldJsrFKVF+B/yOhCfX6x5vL3kO1Tr1Ohrwh9p6H/dUbHp3cr3 jndQm9Hh0fyjLMp+25M6JnhISmpJ8MWRUwm3bM6X6AQh3IpM4DC/c6ARuLRDfjuVkiKj Jlz1/M8gms6QlmFG6TORa3G+EWBIO4W2Zhj5oB7QX7l7GixJBtC5GXM0m71alchrF+cu TaAIkO4rfkpFKt9uXG+aq4wwBCVkbfgoP0RPsL7R0Jdi0kDdYd/EChTXWheBxCVmTotU k4Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=17c8XpxOUV6PMKBGkT6hgRc9wmj0RfqUb4n9M0h3sFA=; b=aa/zgNJd3/CoLlkES4ZVjyNyoFPRdClUsD01GELsMDBAhSUFHYcKVggDtq1qn2bPNG 6igpR/U6AdAaOTFFgLe8Hqs7i/a23SJp60ZPBQlWRGXlxI2u5JjFjJDs4oFFnlX48nYq tyJIH/Is5GRx1+9gU+aZ70VmHXl5IGeQqmhZxYcc1HpdfKyBqMKIChQ86lnewQaTQTm7 NkAIp+rX61VqJqJWwPZpM5U9PUWf5G5yuWR1pHJXH++huZ48c6iWvvbBorT9xw7i+Omk b5fqlfTuXcjungZ6xq2q1eiBVja37vWDwIYOY6+Tlu7HvU2RoXZ3Dw/ie4ApoVMYJVgJ jKPQ== X-Gm-Message-State: AE9vXwPm71UddIH78zYikIazHTM0OrFfnFvYhFgzx6yEH/34AcqgotR13nPBctjDd165mgD5REGTJUo5hqV5cg== X-Received: by 10.107.168.195 with SMTP id e64mr22606918ioj.205.1474345144641; Mon, 19 Sep 2016 21:19:04 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.36.65.7 with HTTP; Mon, 19 Sep 2016 21:19:04 -0700 (PDT) X-Originating-IP: [69.53.245.200] In-Reply-To: <20160920034337.GA6180@brick> References: <201609190851.u8J8pRDD068198@repo.freebsd.org> <20160920034337.GA6180@brick> From: Warner Losh Date: Mon, 19 Sep 2016 22:19:04 -0600 X-Google-Sender-Auth: MeHrw3uTv0qDNWXv44P5qJHF_Yo Message-ID: Subject: Re: svn commit: r305968 - head/etc/autofs To: Ronald Klop , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 04:19:05 -0000 For MSDOS it's one thing and likely helps. But for ufs it doesn't help. Soft updates already does an excellent job at reducing wear and all async does is give added danger of dataloss. Linux distros don't matter for UFS because different design decisions have been made for ext[234] and UFS. Warner On Mon, Sep 19, 2016 at 9:43 PM, Edward Tomasz Napierala wrote: > Mounting removable media async improves performance and reduces wear. > And AFAIK that's what most Linux distros used to do. > > On 0919T2032, Ronald Klop wrote: >> Hi, >> >> Your commit message says in words exactly what the diff says in code. >> Would you like to elaborate on why the change is made? I'm curious >> because this could cause severe damage to the filesystem on unclean eject >> of the media. >> >> Regards, >> Ronald. >> >> >> On Mon, 19 Sep 2016 10:51:27 +0200, Edward Tomasz Napierala >> wrote: >> >> > Author: trasz >> > Date: Mon Sep 19 08:51:27 2016 >> > New Revision: 305968 >> > URL: https://svnweb.freebsd.org/changeset/base/305968 >> > >> > Log: >> > Make autofs use the "async" flag for msdosfs and ufs filesystems >> > mounted >> > on /media. >> > MFC after: 1 month >> > >> > Modified: >> > head/etc/autofs/special_media >> > >> > Modified: head/etc/autofs/special_media >> > ============================================================================== >> > --- head/etc/autofs/special_media Mon Sep 19 07:47:56 2016 (r305967) >> > +++ head/etc/autofs/special_media Mon Sep 19 08:51:27 2016 (r305968) >> > @@ -46,6 +46,8 @@ print_map_entry() { >> > "Cannot mount ${_fstype} formatted device /dev/${_p}: Install >> > sysutils/fusefs-ntfs first" >> > exit 1 >> > fi >> > + elif [ "${_fstype}" = "msdosfs" -o "${_fstype}" = "ufs" ]; then >> > + echo "-fstype=${_fstype},nosuid,async :/dev/${_p}" >> > else >> > echo "-fstype=${_fstype},nosuid :/dev/${_p}" >> > fi >> > _______________________________________________ >> > svn-src-all@freebsd.org mailing list >> > https://lists.freebsd.org/mailman/listinfo/svn-src-all >> > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >