From owner-svn-src-head@freebsd.org Mon Aug 20 18:08:04 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 04C401077D3A; Mon, 20 Aug 2018 18:08:04 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4675E7A29F; Mon, 20 Aug 2018 18:08:03 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: by mail-wr1-x434.google.com with SMTP id n2-v6so3242491wrw.7; Mon, 20 Aug 2018 11:08:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:subject:to:cc:references:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YewQkajCbSMk3lagi+HyIFzrU/a9BwNtSzlpKyis5q0=; b=vSi0dHxv+zj3e8dUOAucHbcziqKndyg9Jo0/eiEOg2sCWRztNhsHQDwR/sCd6pGqi6 G4WYX6IXuVJu6i1tgX2+ND/R9JE+0wK+4QfMJ8C92dnJEsxM1T/2z/M4NDbb62tFvGNa fh2sUBWpXToRTwpp4NKzYZhDPRTtxqPQWOSzyJs3i8HWxhsUNMnqQl7ZYe/xlUvYXeZO DRk29i0pytEHXBWCQgKvu0tHcvYwUAE1lmLKJUHYlJdmBbIZHP7lfx2f+YH7SS6PxK+Y FddMgKz0IXk5DM0dFjZNaR8FGo9ebRJWupteznbmVss4Km8GpOmz1cfKSF6zs/vJdnG/ Kw9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:subject:to:cc:references:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=YewQkajCbSMk3lagi+HyIFzrU/a9BwNtSzlpKyis5q0=; b=mAsJn0qMP6h0P4ynvKaOusFVZUndhitPmqybLzbZJ0MSyIiIolJBXgeRSJgUClVaRV HUfbMTX3eKz8Ud/923oOHfHgor1EYMS3VKHUlSi4dYWTYnFmQEABic3HSPZLKRKzqJCM +uzrhUSa25DxfF0XtgYo/E0NxK9ZvfdDQjwqJMYl/II13Ia7l/mNJc2WJ6UBu5fxntfE HUVCUl20Y+uI2YZd/yiIHxzINZOwaD7dIHaSTP1xAlE6h/2oDr0LaD3mpipgAkinH9Oo 2wbOPkNWJ5bN6QDaYhYY5rrtL2aduBYfQ93GiG3It9PYPbXQBprSUn/frhgmK6yEMdEM cHuA== X-Gm-Message-State: APzg51At23Hs72i0oy2Zd5YkXe+FKqHDnEEhVRzm4QRGcRX913awgn9F RQfqHP9Q+qIwpu6H6mDnLrIgIshigIU= X-Google-Smtp-Source: ANB0Vdb0GpJr+SExuKLPrWZhDGr/9T37YdJwE8eWIZZ82OcDmYJf1vFo74l3agGfiX/QQZ9d6o0Tjw== X-Received: by 2002:a5d:69d1:: with SMTP id s17-v6mr5973298wrw.77.1534788481903; Mon, 20 Aug 2018 11:08:01 -0700 (PDT) Received: from [88.208.79.100] (halouny.humusoft.cz. [88.208.79.100]) by smtp.gmail.com with ESMTPSA id e133-v6sm320736wma.33.2018.08.20.11.08.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Aug 2018 11:08:00 -0700 (PDT) From: Michal Meloun X-Google-Original-From: Michal Meloun Reply-To: mmel@freebsd.org Subject: Re: svn commit: r337978 - in head/libexec/rtld-elf: . aarch64 arm mips powerpc powerpc64 riscv To: Kyle Evans Cc: Brooks Davis , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201808171619.w7HGJlZe015255@repo.freebsd.org> <29d939de-108e-c7c4-b4b6-4a7772dca2eb@freebsd.org> Openpgp: preference=signencrypt Autocrypt: addr=mmel@freebsd.org; prefer-encrypt=mutual; keydata= xsBNBFYuVRkBCADZiwLCCne3wG9b9k+R2Neo5zVo2bLaZRfNNY/v9kg283i0sb1Da4EdEiNT 15El5UyozhphUIbIR/zrVpxF1TvvFdoCyzx6a68bNY2d9dBrDcNDZC+XnyDdHQoobN87DWT1 mRVkmbg9LHZ/SVUOkGYuWyE+8UYeDAcUizuXwSK5zFWmeTyIoWNa68ifrWLfQe0p4x5jC/AI VURCi17p360vU4fhgwoMvEEhrRBWCr4DYHToFjIt2WdBy3GR1qoO0+Xkd6G+OoBULo+XDfgu L2WdPvh0K69F9/LgHkMmG5Il7SCe62QGpG2vaCgRV7BQhLX+kxlvM+WrdRatWRml4Y/3ABEB AAHNIE1pY2hhbCBNZWxvdW4gPG1tZWxAZnJlZWJzZC5vcmc+wsCABBMBCgAqAhsDBQsJCAcD BRUKCQgLBRYDAgEAAh4BAheAAhkBBQJZjBHDBQkHICOqAAoJEGkesmtexaqqIKMIAJ9xTp1w ge86ns2ZYOac5++mAgpFatohSlxYUR3gwud3Y3Ej0eumavpv/C26N6dsLnspwRenKdLbIPKe 0N8lI7CcDBIJGiFyY3c4H79QjIkYpRgbWFyCM85zEyVJpB+U7BhsgXE2uwVjE9RNhEP0KBoj sp357uqq1B1+VUO4GJ+RjdmYSOcNrjR8tTfy02456qovGjJ4JcJBlhyK6GzBKvnZSoA0s+QP OMn3gd8gdomMLEJdS3kTsfhLh2rQPZa9EmzafIyjXrirWq4+4fVFgd8SiMZyyTM+Kz30ZSUe 6SmfaQTQ/WLRIl5jku2uYQWlrRIKT9xaQzRWtZO9UgtXFRHOwE0EVi5VGQEIALqgRkfS21D/ OqWE9mXfh2bIjrp9uC8T0MCuimbsrAdLKNNorGu2nE+rebgX8n5nYM377HOnalPGyOuXvCbQ 8MFVRdWOHxenJjXJialNdBsOf2wLva3vSSVsdoPzibWDIcJqhBOQ3EuhsILyWSPvYYKEiy95 mfhrDtuTTOAYVR9aNQBOENztB2TDJyMx/qZmtGroGV3N0Hqde/znHPtQO8RG5/FQGMfHMI5G FMuycr1ceHnLo/ovrqAl4TYV+UHSHJ+FDE9dt9wXHclWbWbC0yNugchZq6rho5Jjfv4a2v7P pyn3HoDinh1lWP7hYA0ZNExGHekLnXWVqO/lzGS6bMEAEQEAAcLAZQQYAQoADwIbDAUCWYwR wwUJByAjqgAKCRBpHrJrXsWqqrsrB/4g4ESK5TLxUxi8pLWcLPyvwtN4Fmf7VsCVefkhakaG rDPmfvfnG+OFwN60Xqoni7GBeakl01xwT4RINfvVfShDy6cHpLS7QL/M8pzfulVX38MkVkOD yGZhwjE+jyT/kZNA1Olaw3N3IefHq3brskQ7G4d9oPep2DDbw7C4Q76uOBjxy34JVB0WOsB6 NyMQB9h6LGljQtdEddyUqwnRZzzHiGvp0hPtdYQHQZlqbj4FV9lTRK7a8Ega+y7MgmeMiztG zeXyjNP02r3PRHCPagwa57bPxH2aAh4Q7UzBBZ0GTMm7DLKNtCP58WDxblrrhZ+7kHqGK8Fs bdeUpDdEYLVd Message-ID: Date: Mon, 20 Aug 2018 20:08:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2018 18:08:04 -0000 On 20.08.2018 18:02, Kyle Evans wrote: > On Mon, Aug 20, 2018 at 11:00 AM, Michal Meloun wrote: >> >> >> On 17.08.2018 18:19, Brooks Davis wrote: >>> Author: brooks >>> Date: Fri Aug 17 16:19:47 2018 >>> New Revision: 337978 >>> URL: https://svnweb.freebsd.org/changeset/base/337978 >>> >>> Log: >>> Rework rtld's TLS Variant I implementation to match r326794 >>> >>> The above commit fixed handling overaligned TLS segments in libc's >>> TLS Variant I implementation, but rtld provides its own implementation >>> for dynamically-linked executables which lacks these fixes. Thus, >>> port these changes to rtld. >>> >>> Submitted by: James Clarke >>> Reviewed by: kbowling >>> Testing byL kbowling (powerpc64), br (riscv), kevans (armv7) >>> Obtained from: CheriBSD >>> Sponsored by: DARPA, AFRL >>> Differential Revision: https://reviews.freebsd.org/D16510 >>> >>> Modified: >>> head/libexec/rtld-elf/aarch64/rtld_machdep.h >>> head/libexec/rtld-elf/arm/rtld_machdep.h >>> head/libexec/rtld-elf/mips/rtld_machdep.h >>> head/libexec/rtld-elf/powerpc/rtld_machdep.h >>> head/libexec/rtld-elf/powerpc64/rtld_machdep.h >>> head/libexec/rtld-elf/riscv/rtld_machdep.h >>> head/libexec/rtld-elf/rtld.c >>> >> This commit breaks TLS handling for (at least) armv7. Can you please >> revert it until I will be able to identify where is problem? >> In my case, the libc _ThreadRuneLocale symbol is not zero on program start. >> > > Interesting that I didn't hit this on my armv7 test > No idea yet. For me, it breaks all ctype (isspace()..) related function. Originally, I found that bash port gets broken. Its funny if shell takes 'a' as non-alphanumeric character, 'x' as whitespace, ... Anyway, give me a while - I need to write testcase because bas is too complex for effective debugging. This commit isn't fundamentally bad, it works for jemalloc thread local variables so I think that only some edge case (tbss handling is my candidate) is affected. Michal