From nobody Sat Aug 19 07:40:15 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RSVyX3yYBz4qMZZ; Sat, 19 Aug 2023 07:40:20 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RSVyW2Jkyz4XP0; Sat, 19 Aug 2023 07:40:19 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: by mail.gandi.net (Postfix) with ESMTPA id 444A320003; Sat, 19 Aug 2023 07:40:15 +0000 (UTC) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Date: Sat, 19 Aug 2023 09:40:15 +0200 From: Daniel Engberg To: Jan Beich Cc: Po-Chuan Hsieh , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 616e8c13a4ce - main - devel/utf8cpp: Update to 3.2.4 In-Reply-To: References: <202308161944.37GJifUD062454@gitrepo.freebsd.org> <5be35ca3e7ac2390fdbce2e4792223b5@pyret.net> Message-ID: <3740bc927d27be9617ea40809a7a91fd@pyret.net> X-Sender: daniel.engberg.lists@pyret.net Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-GND-Sasl: daniel.engberg@pyret.net X-Rspamd-Queue-Id: 4RSVyW2Jkyz4XP0 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR] On 2023-08-19 09:09, Jan Beich wrote: > Daniel Engberg writes: > >> On 2023-08-16 21:44, Po-Chuan Hsieh wrote: >>> --- a/devel/utf8cpp/Makefile >>> +++ b/devel/utf8cpp/Makefile >>> @@ -1,9 +1,9 @@ >>> PORTNAME= utf8cpp >>> +PORTVERSION= 3.2.4 >>> DISTVERSIONPREFIX= v >>> -DISTVERSION= 3.2.3 > [...] >> Can you please revert you changes so the port don't deviate from >> Porters Handbook? >> https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github >> - Example 16 > > Did you overquote the whole commit just for DISTVERSION vs. PORTVERSION > ? > Neither portlint nor portclippy warn about mixing PORTVERSION with > DISTVERSIONPREFIX. > >>> @@ -11,20 +11,14 @@ LICENSE= BSL >>> LICENSE_FILE= ${WRKSRC}/LICENSE >>> USES= cmake >>> -USE_GITHUB= yes >>> -GH_ACCOUNT= nemtrif >>> -GH_PROJECT= utfcpp >>> + >>> +CMAKE_ON= UTF8_INSTALL >>> +CMAKE_OFF= UTF8_SAMPLES UTF8_TESTS >>> NO_ARCH= yes >>> -PLIST_FILES= include/utf8cpp/utf8.h \ >>> - include/utf8cpp/utf8/checked.h \ >>> - include/utf8cpp/utf8/core.h \ >>> - include/utf8cpp/utf8/cpp11.h \ >>> - include/utf8cpp/utf8/cpp17.h \ >>> - include/utf8cpp/utf8/unchecked.h \ >>> - lib/cmake/utf8cpp/utf8cppConfig.cmake \ >>> - lib/cmake/utf8cpp/utf8cppConfigVersion.cmake \ >>> - lib/cmake/utf8cpp/utf8cppTargets.cmake >>> +USE_GITHUB= yes >>> +GH_ACCOUNT= nemtrif >>> +GH_PROJECT= utfcpp > > Another style regression: out of order USE_GITHUB group of variables. > https://docs.freebsd.org/en/books/porters-handbook/order/#porting-order-uses > Noticed via portclippy from ports-mgmt/portfmt. ...and ordering indeed DISTVERSIONPREFIX after DISTVERSION, USE_GITUB - Example 19,20 etc Just as you noted Best regards, Daniel