From owner-svn-src-all@FreeBSD.ORG  Wed Sep 29 11:52:44 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 61644106566C;
	Wed, 29 Sep 2010 11:52:44 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 511988FC0C;
	Wed, 29 Sep 2010 11:52:44 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o8TBqisJ008133;
	Wed, 29 Sep 2010 11:52:44 GMT (envelope-from jhb@svn.freebsd.org)
Received: (from jhb@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id o8TBqioi008131;
	Wed, 29 Sep 2010 11:52:44 GMT (envelope-from jhb@svn.freebsd.org)
Message-Id: <201009291152.o8TBqioi008131@svn.freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Date: Wed, 29 Sep 2010 11:52:44 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r213268 - head/sys/dev/ral
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Sep 2010 11:52:44 -0000

Author: jhb
Date: Wed Sep 29 11:52:44 2010
New Revision: 213268
URL: http://svn.freebsd.org/changeset/base/213268

Log:
  If rt2560_bbp_init() fails, don't drop the lock as the callers of
  rt2560_init_locked() expect the lock to be held on return.
  
  Reported by:	Anton Shterenlikht  mexas of bristol ac uk
  MFC after:	1 week

Modified:
  head/sys/dev/ral/rt2560.c

Modified: head/sys/dev/ral/rt2560.c
==============================================================================
--- head/sys/dev/ral/rt2560.c	Wed Sep 29 09:40:20 2010	(r213267)
+++ head/sys/dev/ral/rt2560.c	Wed Sep 29 11:52:44 2010	(r213268)
@@ -2667,8 +2667,7 @@ rt2560_init_locked(struct rt2560_softc *
 	RAL_WRITE(sc, RT2560_CSR1, RT2560_HOST_READY);
 
 	if (rt2560_bbp_init(sc) != 0) {
-		rt2560_stop(sc);
-		RAL_UNLOCK(sc);
+		rt2560_stop_locked(sc);
 		return;
 	}